[commit: ghc] master: Comment a suspicious zonk in TcFlatten. (9477093)

git at git.haskell.org git at git.haskell.org
Mon Mar 21 20:10:37 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/947709395015bd6122eedc6da5df356660e76208/ghc

>---------------------------------------------------------------

commit 947709395015bd6122eedc6da5df356660e76208
Author: Richard Eisenberg <eir at cis.upenn.edu>
Date:   Fri Mar 18 22:37:37 2016 -0400

    Comment a suspicious zonk in TcFlatten.


>---------------------------------------------------------------

947709395015bd6122eedc6da5df356660e76208
 compiler/typecheck/TcFlatten.hs | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/compiler/typecheck/TcFlatten.hs b/compiler/typecheck/TcFlatten.hs
index 491888e..4971eb1 100644
--- a/compiler/typecheck/TcFlatten.hs
+++ b/compiler/typecheck/TcFlatten.hs
@@ -1346,6 +1346,9 @@ flatten_tyvar3 tv
 --                 , ppr kind_co <+> dcolon <+> ppr (coercionKind kind_co) ])
        ; orig_kind <- liftTcS $ zonkTcType kind
              -- NB: orig_kind is *not* the kind returned from flatten
+             -- This zonk is necessary because we might later see the tv's kind
+             -- in canEqTyVarTyVar (where we use getCastedTyVar_maybe).
+             -- If you remove it, then e.g. dependent/should_fail/T11407 panics
        ; return (FTRCasted (setTyVarKind tv orig_kind) kind_co) }
 
 {-



More information about the ghc-commits mailing list