[commit: ghc] wip/generalized-arrow: Render type equality more readably (90ad65d)

git at git.haskell.org git at git.haskell.org
Mon Mar 21 17:11:00 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/generalized-arrow
Link       : http://ghc.haskell.org/trac/ghc/changeset/90ad65d3c487d6e7c6f6303b0487ce4caa8eae9b/ghc

>---------------------------------------------------------------

commit 90ad65d3c487d6e7c6f6303b0487ce4caa8eae9b
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Wed Mar 16 11:37:27 2016 +0100

    Render type equality more readably


>---------------------------------------------------------------

90ad65d3c487d6e7c6f6303b0487ce4caa8eae9b
 compiler/types/TyCoRep.hs | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/compiler/types/TyCoRep.hs b/compiler/types/TyCoRep.hs
index fa123a0..86d236c 100644
--- a/compiler/types/TyCoRep.hs
+++ b/compiler/types/TyCoRep.hs
@@ -2801,6 +2801,19 @@ pprTcApp_help to_type p pp tc tys dflags style
                                -- we know nothing of precedence though
   = pprInfixApp p pp pp_tc ty1 ty2
 
+  -- Handle equalities specifically
+  | is_het_equality
+  , [k1,k2,ty1,ty2] <- map to_type tys_wo_kinds
+  =   parens (pprType ty1 <+> dcolon <+> pprKind k1)
+  <+> text "~~"
+  <+> parens (pprType ty2 <+> dcolon <+> pprKind k2)
+
+  | is_equality
+  , [k,ty1,ty2] <- map to_type tys_wo_kinds
+  =   parens (pprType ty1 <+> dcolon <+> pprKind k)
+  <+> text "~"
+  <+> parens (pprType ty2 <+> dcolon <+> pprKind k)
+
   |  tc_name `hasKey` starKindTyConKey
   || tc_name `hasKey` unicodeStarKindTyConKey
   || tc_name `hasKey` unliftedTypeKindTyConKey
@@ -2810,12 +2823,14 @@ pprTcApp_help to_type p pp tc tys dflags style
   = pprPrefixApp p (parens pp_tc) (map (pp TyConPrec) tys_wo_kinds)
   where
     tc_name = tyConName tc
+    is_het_equality = tc `hasKey` heqTyConKey
+    is_equality = tc `hasKey` eqPrimTyConKey || is_het_equality
 
      -- With the solver working in unlifted equality, it will want to
      -- to print unlifted equality constraints sometimes. But these are
      -- confusing to users. So fix them up here.
     (print_prefix, pp_tc)
-      | (tc `hasKey` eqPrimTyConKey || tc `hasKey` heqTyConKey) && not print_eqs
+      | is_equality && not print_eqs
       = (False, text "~")
       | tc `hasKey` eqReprPrimTyConKey && not print_eqs
       = (True, text "Coercible")



More information about the ghc-commits mailing list