[commit: ghc] master: Delete Ord Unique (fb6e2c7)

git at git.haskell.org git at git.haskell.org
Thu Jun 30 12:53:16 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/fb6e2c7fe213004c7398a13e3cc38d4428b66b12/ghc

>---------------------------------------------------------------

commit fb6e2c7fe213004c7398a13e3cc38d4428b66b12
Author: Bartosz Nitka <niteria at gmail.com>
Date:   Wed Jun 29 07:34:55 2016 -0700

    Delete Ord Unique
    
    Ord Unique can be a source of invisible, accidental
    nondeterminism as explained in Note [No Ord for Unique].
    This removes it, leaving a note with rationale.
    
    It's unfortunate that I had to write Ord instances for
    codegen data structures by hand, but I believe that it's a
    right trade-off here.
    
    Test Plan: ./validate
    
    Reviewers: simonmar, austin, bgamari
    
    Reviewed By: simonmar
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D2370
    
    GHC Trac Issues: #4012


>---------------------------------------------------------------

fb6e2c7fe213004c7398a13e3cc38d4428b66b12
 compiler/basicTypes/DataCon.hs      |  7 ---
 compiler/basicTypes/DataCon.hs-boot |  1 -
 compiler/basicTypes/Module.hs       |  4 +-
 compiler/basicTypes/Unique.hs       | 47 +++++++++++++++-----
 compiler/cmm/CLabel.hs              | 87 ++++++++++++++++++++++++++++++++++++-
 compiler/cmm/CmmCommonBlockElim.hs  |  8 ++--
 compiler/cmm/CmmExpr.hs             |  5 ++-
 compiler/cmm/CmmNode.hs             | 22 +++++++---
 compiler/nativeGen/Reg.hs           | 23 +++++++++-
 9 files changed, 169 insertions(+), 35 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc fb6e2c7fe213004c7398a13e3cc38d4428b66b12


More information about the ghc-commits mailing list