[commit: ghc] master: Derive instances in Data.Data (4842a80)
git at git.haskell.org
git at git.haskell.org
Fri Jun 3 18:45:03 UTC 2016
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/4842a8050058bb571db861be3fc5ec03a1b4274b/ghc
>---------------------------------------------------------------
commit 4842a8050058bb571db861be3fc5ec03a1b4274b
Author: Ryan Scott <ryan.gl.scott at gmail.com>
Date: Fri Jun 3 14:48:16 2016 -0400
Derive instances in Data.Data
Summary:
Currently, none of the `Data` instances in `Data.Data` are derived,
which has resulted in hundreds of lines of laboriously hand-written `Data`
instances. This cleans it up by using `DeriveDataTypeable` to derive all of
the boring instances.
Note that previously, `tcTopSrcDecls` in `TcRnDriver` was typechecking the
variables generated in `deriving` statements before other top-level variables,
which causes an error when `DeriveDataTypeable` is used in `Data.Data`, since
the `deriving`-generated variable definitions refer to top-level definitions
in `Data.Data` itself. To fix this, the order in which these two groups are
typechecked was reversed.
Test Plan: ./validate
Reviewers: rwbarton, bgamari, hvr, austin
Reviewed By: austin
Subscribers: rwbarton, thomie
Differential Revision: https://phabricator.haskell.org/D2291
>---------------------------------------------------------------
4842a8050058bb571db861be3fc5ec03a1b4274b
compiler/typecheck/TcRnDriver.hs | 17 +-
libraries/base/Data/Data.hs | 755 +++------------------------------------
2 files changed, 69 insertions(+), 703 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 4842a8050058bb571db861be3fc5ec03a1b4274b
More information about the ghc-commits
mailing list