[commit: ghc] master: Kill nameSetElems in findImportUsage (e2446c0)

git at git.haskell.org git at git.haskell.org
Thu Jun 2 19:46:40 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/e2446c0d688d63e66fb1ae81cd2ebfa321ebc913/ghc

>---------------------------------------------------------------

commit e2446c0d688d63e66fb1ae81cd2ebfa321ebc913
Author: Bartosz Nitka <niteria at gmail.com>
Date:   Thu Jun 2 11:37:41 2016 -0700

    Kill nameSetElems in findImportUsage
    
    nameSetElems is nondeterministic and while I think we don't need
    determinism here it doesn't hurt.
    
    Test Plan: ./validate
    
    Reviewers: ezyang, bgamari, austin, simonmar
    
    Reviewed By: simonmar
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D2293
    
    GHC Trac Issues: #4012


>---------------------------------------------------------------

e2446c0d688d63e66fb1ae81cd2ebfa321ebc913
 compiler/rename/RnNames.hs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compiler/rename/RnNames.hs b/compiler/rename/RnNames.hs
index 40049bf..2fc6263 100644
--- a/compiler/rename/RnNames.hs
+++ b/compiler/rename/RnNames.hs
@@ -1655,7 +1655,7 @@ findImportUsage imports used_gres
       = foldr extendImportMap Map.empty used_gres
 
     unused_decl decl@(L loc (ImportDecl { ideclHiding = imps }))
-      = (decl, nubAvails used_avails, nameSetElems unused_imps)
+      = (decl, nubAvails used_avails, nameSetElemsStable unused_imps)
       where
         used_avails = Map.lookup (srcSpanEnd loc) import_usage `orElse` []
                       -- srcSpanEnd: see Note [The ImportMap]



More information about the ghc-commits mailing list