[commit: ghc] wip/ghc-8.0-det: Make Arrow desugaring deterministic (5ba488f)

Mon Jul 25 14:59:01 UTC 2016

Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/ghc-8.0-det
Link       : http://ghc.haskell.org/trac/ghc/changeset/5ba488f66e35911d57b3a224c0467c864334e54e/ghc

>---------------------------------------------------------------

commit 5ba488f66e35911d57b3a224c0467c864334e54e
Author: Bartosz Nitka <niteria at gmail.com>
Date:   Tue May 24 04:44:37 2016 -0700

    Make Arrow desugaring deterministic

    This kills two instances of varSetElems that turned out to be
    nondeterministic. I've tried to untangle this before, but it's
    a bit hard with the fixDs in the middle. Fortunately I now have
    a test case that proves that we need determinism here.

    Test Plan: ./validate, new testcase

    Reviewers: simonpj, simonmar, austin, bgamari

    Reviewed By: bgamari

    Subscribers: thomie

    Differential Revision: https://phabricator.haskell.org/D2258

    GHC Trac Issues: #4012

    (cherry picked from commit 9d06ef1ae451a145607301dc7556931b537a7d83)

>---------------------------------------------------------------

5ba488f66e35911d57b3a224c0467c864334e54e
 compiler/coreSyn/CoreFVs.hs                        | 33 ++++++++++++
 compiler/deSugar/DsArrows.hs                       | 63 +++++++++++-----------
 compiler/utils/UniqDFM.hs                          |  7 ++-
 testsuite/tests/determinism/determ018/A.hs         | 32 +++++++++++
 .../determinism/{determ013 => determ018}/Makefile  |  2 +-
 .../determinism/{determ009 => determ018}/all.T     |  4 +-
 .../determ018.stdout}                              |  0
 7 files changed, 106 insertions(+), 35 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 5ba488f66e35911d57b3a224c0467c864334e54e