[commit: ghc] master: Bring comments in TcGenGenerics up to date (b35e01c)
git at git.haskell.org
git at git.haskell.org
Fri Jul 15 18:18:36 UTC 2016
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/b35e01c6c39d9f2d58009722e24d89049aa94287/ghc
>---------------------------------------------------------------
commit b35e01c6c39d9f2d58009722e24d89049aa94287
Author: Ryan Scott <ryan.gl.scott at gmail.com>
Date: Fri Jul 15 14:17:24 2016 -0400
Bring comments in TcGenGenerics up to date
[ci skip]
>---------------------------------------------------------------
b35e01c6c39d9f2d58009722e24d89049aa94287
compiler/typecheck/TcGenGenerics.hs | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/compiler/typecheck/TcGenGenerics.hs b/compiler/typecheck/TcGenGenerics.hs
index a734ae8..5757e98 100644
--- a/compiler/typecheck/TcGenGenerics.hs
+++ b/compiler/typecheck/TcGenGenerics.hs
@@ -135,7 +135,8 @@ canDoGenerics :: TyCon -> Validity
-- Check (a) from Note [Requirements for deriving Generic and Rep] is taken
-- care of because canDoGenerics is applied to rep tycons.
--
--- It returns Nothing if deriving is possible. It returns (Just reason) if not.
+-- It returns IsValid if deriving is possible. It returns (NotValid reason)
+-- if not.
canDoGenerics tc
= mergeErrors (
-- Check (b) from Note [Requirements for deriving Generic and Rep].
@@ -221,7 +222,8 @@ explicitly, even though foldDataConArgs is also doing this internally.
-- Checks (a) through (c) from Note [Requirements for deriving Generic and Rep]
-- are taken care of by the call to canDoGenerics.
--
--- It returns Nothing if deriving is possible. It returns (Just reason) if not.
+-- It returns IsValid if deriving is possible. It returns (NotValid reason)
+-- if not.
canDoGenerics1 :: TyCon -> Validity
canDoGenerics1 rep_tc =
canDoGenerics rep_tc `andValid` additionalChecks
More information about the ghc-commits
mailing list