[commit: ghc] master: Check generic-default method for ambiguity (85aa6ef)

git at git.haskell.org git at git.haskell.org
Tue Jul 5 12:50:54 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/85aa6ef09346e841abf4e089b24c7f783286cd74/ghc

>---------------------------------------------------------------

commit 85aa6ef09346e841abf4e089b24c7f783286cd74
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date:   Fri Jul 1 22:33:33 2016 +0100

    Check generic-default method for ambiguity
    
    Fixes Trac #7497 and #12151.   In some earlier upheaval I introduced
    a bug in the ambiguity check for genreric-default method.
    
    This patch fixes it.  But in fixing it I realised that the
    sourc-location of any such error message was bogus, so I fixed
    that too, which involved a slightly wider change; see the
    comments with TcMethInfo.


>---------------------------------------------------------------

85aa6ef09346e841abf4e089b24c7f783286cd74
 compiler/iface/BuildTyCl.hs                        | 47 +++++++++++++++++-----
 compiler/iface/TcIface.hs                          |  4 +-
 compiler/typecheck/TcClassDcl.hs                   |  8 ++--
 compiler/typecheck/TcTyClsDecls.hs                 | 16 +++++---
 compiler/typecheck/TcTyDecls.hs                    | 19 ++++-----
 compiler/types/Class.hs                            | 10 +----
 compiler/vectorise/Vectorise/Type/TyConDecl.hs     |  9 +++++
 testsuite/tests/typecheck/should_fail/T12151.hs    | 10 +++++
 .../tests/typecheck/should_fail/T12151.stderr      | 12 ++++++
 testsuite/tests/typecheck/should_fail/T7437.hs     | 15 +++++++
 testsuite/tests/typecheck/should_fail/T7437.stderr | 12 ++++++
 testsuite/tests/typecheck/should_fail/all.T        |  2 +
 12 files changed, 125 insertions(+), 39 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 85aa6ef09346e841abf4e089b24c7f783286cd74


More information about the ghc-commits mailing list