[commit: ghc] master: Add asserts to other substitution functions (bb956eb)

git at git.haskell.org git at git.haskell.org
Sat Jan 30 16:40:13 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/bb956eb8d8774613c1e311655f1359a91a84765b/ghc

>---------------------------------------------------------------

commit bb956eb8d8774613c1e311655f1359a91a84765b
Author: Bartosz Nitka <niteria at gmail.com>
Date:   Wed Jan 27 08:37:30 2016 -0800

    Add asserts to other substitution functions
    
    This adds asserts to `substTys`, `substCo` and `substCos` in
    the same spirit as already existing asserts on `substTy`, protecting
    every possible entry point to `subst_ty` and `subst_co`.
    
    I've replaced the violators with unchecked versions.
    
    Test Plan: ./validate --slow
    
    Reviewers: simonpj, goldfire, austin, bgamari
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D1862
    
    GHC Trac Issues: #11371


>---------------------------------------------------------------

bb956eb8d8774613c1e311655f1359a91a84765b
 compiler/basicTypes/MkId.hs    |   2 +-
 compiler/coreSyn/CoreLint.hs   |   2 +-
 compiler/coreSyn/CoreUtils.hs  |   2 +-
 compiler/deSugar/DsExpr.hs     |   2 +-
 compiler/typecheck/FunDeps.hs  |   2 +-
 compiler/typecheck/Inst.hs     |  10 +-
 compiler/typecheck/TcExpr.hs   |   6 +-
 compiler/typecheck/TcSMonad.hs |   2 +-
 compiler/typecheck/TcType.hs   |   5 +-
 compiler/types/Coercion.hs     |   6 +-
 compiler/types/OptCoercion.hs  |   2 +-
 compiler/types/TyCoRep.hs      | 232 +++++++++++++++++++++++++++++++++--------
 compiler/types/Type.hs         |  19 ++--
 13 files changed, 222 insertions(+), 70 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc bb956eb8d8774613c1e311655f1359a91a84765b


More information about the ghc-commits mailing list