[commit: ghc] master: Enable RemoteGHCi on Windows (44a5d51)

git at git.haskell.org git at git.haskell.org
Wed Jan 27 09:51:54 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/44a5d51a4892b85c7eba09dcb90ca02245637812/ghc

>---------------------------------------------------------------

commit 44a5d51a4892b85c7eba09dcb90ca02245637812
Author: Tamar Christina <tamar at zhox.com>
Date:   Wed Jan 27 10:20:11 2016 +0100

    Enable RemoteGHCi on Windows
    
    Makes the needed changes to make RemoteGHCi work on Windows.
    The approach passes OS Handles areound instead of the Posix Fd
    as on Linux.
    
    The reason is that I could not find any real documentation about
    the behaviour of Windows w.r.t inheritance and Posix FDs.
    
    The implementation with Fd did not seem to be able to find the Fd
    in the child process. Instead I'm using the much better documented
    approach of passing inheriting handles.
    
    This requires a small modification to the `process` library.
    https://github.com/haskell/process/pull/52
    
    Test Plan: ./validate On Windows x86_64
    
    Reviewers: thomie, erikd, bgamari, simonmar, austin, hvr
    
    Reviewed By: simonmar
    
    Subscribers: #ghc_windows_task_force
    
    Differential Revision: https://phabricator.haskell.org/D1836
    
    GHC Trac Issues: #11100


>---------------------------------------------------------------

44a5d51a4892b85c7eba09dcb90ca02245637812
 .gitignore                    |  1 +
 compiler/ghci/GHCi.hs         | 61 +++++++++++++++++++++++++++----------------
 compiler/main/DynFlags.hs     |  7 -----
 ghc.mk                        |  2 --
 iserv/{ => cbits}/iservmain.c |  0
 iserv/iserv-bin.cabal         |  8 ++++--
 iserv/src/GHCi/Utils.hsc      | 25 ++++++++++++++++++
 iserv/{ => src}/Main.hs       | 10 +++----
 mk/warnings.mk                |  5 ++++
 9 files changed, 81 insertions(+), 38 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 44a5d51a4892b85c7eba09dcb90ca02245637812


More information about the ghc-commits mailing list