[commit: ghc] master: Refactor validity checking for type/data instances (746764c)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/746764cce9a111a082a13bc3cd34b50e34fd2a31/ghc

>---------------------------------------------------------------

commit 746764cce9a111a082a13bc3cd34b50e34fd2a31
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date:   Fri Jan 22 16:40:55 2016 +0000

    Refactor validity checking for type/data instances
    
    I found that there was some code duplication going on,
    so I've put more into the shared function checkValidFamPats.
    
    I did some refactoring in checkConsistentFamInst too,
    preparatory to #11450; the error messages change a little
    but no change in behaviour.


>---------------------------------------------------------------

746764cce9a111a082a13bc3cd34b50e34fd2a31
 compiler/typecheck/TcInstDcls.hs                   |   9 +-
 compiler/typecheck/TcTyClsDecls.hs                 |   2 +
 compiler/typecheck/TcValidity.hs                   | 152 ++++++++++++---------
 .../indexed-types/should_fail/SimpleFail2a.stderr  |  11 +-
 4 files changed, 100 insertions(+), 74 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 746764cce9a111a082a13bc3cd34b50e34fd2a31