[commit: ghc] master: un-wire-in error, undefined, CallStack, and IP (a7b751d)

git at git.haskell.org git at git.haskell.org
Mon Jan 18 10:23:57 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/a7b751db766bd456ace4f76a861e5e8b927d8f17/ghc

>---------------------------------------------------------------

commit a7b751db766bd456ace4f76a861e5e8b927d8f17
Author: Eric Seidel <gridaphobe at gmail.com>
Date:   Mon Jan 18 09:45:23 2016 +0100

    un-wire-in error, undefined, CallStack, and IP
    
    I missed a crucial step in the wiring-in process of `CallStack` in D861,
    the bit where you actually wire-in the Name... This led to a nasty bug
    where GHC thought `CallStack` was not wired-in and tried to fingerprint
    it, which failed because the defining module was not loaded.
    
    But we don't need `CallStack` to be wired-in anymore since `error` and
    `undefined` no longer need to be wired-in. So we just remove them all.
    
    Updates haddock submodule.
    
    Test Plan: `./validate` and `make slowtest TEST=tc198`
    
    Reviewers: simonpj, goldfire, austin, hvr, bgamari
    
    Reviewed By: simonpj, bgamari
    
    Subscribers: goldfire, thomie
    
    Projects: #ghc
    
    Differential Revision: https://phabricator.haskell.org/D1739
    
    GHC Trac Issues: #11331


>---------------------------------------------------------------

a7b751db766bd456ace4f76a861e5e8b927d8f17
 compiler/coreSyn/MkCore.hs       | 56 +++-------------------------------
 compiler/iface/IfaceType.hs      |  4 +--
 compiler/main/HscTypes.hs        |  2 +-
 compiler/prelude/PrelNames.hs    | 35 ++++++++++-----------
 compiler/prelude/TysWiredIn.hs   | 66 ----------------------------------------
 compiler/typecheck/TcBinds.hs    |  6 ++--
 compiler/typecheck/TcExpr.hs     |  1 +
 compiler/typecheck/TcGenDeriv.hs |  6 ++--
 compiler/typecheck/TcHsType.hs   |  1 +
 compiler/typecheck/TcInteract.hs |  6 ++--
 compiler/typecheck/TcRnTypes.hs  |  7 +++--
 compiler/types/TyCoRep.hs        |  2 +-
 compiler/types/Type.hs           |  6 ++--
 libraries/base/GHC/Err.hs        | 14 ++++++---
 utils/haddock                    |  2 +-
 15 files changed, 53 insertions(+), 161 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc a7b751db766bd456ace4f76a861e5e8b927d8f17


More information about the ghc-commits mailing list