[commit: ghc] ghc-8.0: (Alternative way to) address #8710 (680557c)
git at git.haskell.org
git at git.haskell.org
Sat Feb 27 15:57:08 UTC 2016
Repository : ssh://git@git.haskell.org/ghc
On branch : ghc-8.0
Link : http://ghc.haskell.org/trac/ghc/changeset/680557c125021a1f248ef010418b1234d9a2aa4a/ghc
>---------------------------------------------------------------
commit 680557c125021a1f248ef010418b1234d9a2aa4a
Author: George Karachalias <george.karachalias at gmail.com>
Date: Thu Feb 25 15:50:35 2016 +0100
(Alternative way to) address #8710
Issue a separate warning per redundant (or inaccessible) clause.
This way each warning can have more precice location information
(the location of the clause under consideration and not the whole
match).
I thought that this could be too much but actually the number of
such warnings is bound by the number of cases matched against (in
contrast to the non-exhaustive warnings which may be exponentially
more).
Test Plan: validate
Reviewers: simonpj, austin, bgamari
Reviewed By: bgamari
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D1920
GHC Trac Issues: #8710
(cherry picked from commit 67393977489942ef41f4f7d4a77076c15db18b92)
>---------------------------------------------------------------
680557c125021a1f248ef010418b1234d9a2aa4a
compiler/deSugar/Check.hs | 45 +++++++++++++---------
.../tests/deSugar/should_compile/T2395.stderr | 4 +-
.../tests/deSugar/should_compile/T5117.stderr | 4 +-
.../tests/deSugar/should_compile/ds002.stderr | 16 ++++----
.../tests/deSugar/should_compile/ds003.stderr | 12 +++---
.../tests/deSugar/should_compile/ds019.stderr | 17 +++++---
.../tests/deSugar/should_compile/ds020.stderr | 24 ++++++------
.../tests/deSugar/should_compile/ds022.stderr | 12 +++---
.../tests/deSugar/should_compile/ds043.stderr | 4 +-
.../tests/deSugar/should_compile/ds051.stderr | 12 +++---
.../tests/deSugar/should_compile/ds056.stderr | 4 +-
.../tests/deSugar/should_compile/ds058.stderr | 4 +-
testsuite/tests/driver/werror.stderr | 8 ++--
testsuite/tests/gadt/T7294.stderr | 4 +-
testsuite/tests/ghci/scripts/Defer02.stderr | 4 +-
.../tests/pmcheck/should_compile/pmc003.stderr | 5 ++-
.../tests/pmcheck/should_compile/pmc004.stderr | 5 ++-
.../tests/pmcheck/should_compile/pmc005.stderr | 7 ++--
testsuite/tests/th/TH_repUnboxedTuples.stderr | 2 +-
.../tests/typecheck/should_compile/T5490.stderr | 8 ++--
20 files changed, 112 insertions(+), 89 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 680557c125021a1f248ef010418b1234d9a2aa4a
More information about the ghc-commits
mailing list