[commit: ghc] master: testsuite: Separate out Windows results for T5205 (d398162)

git at git.haskell.org git at git.haskell.org
Thu Dec 15 18:07:53 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/d39816285341cf639b51ae14f65c63a3e89bba95/ghc

>---------------------------------------------------------------

commit d39816285341cf639b51ae14f65c63a3e89bba95
Author: Ben Gamari <bgamari.foss at gmail.com>
Date:   Thu Dec 15 11:18:05 2016 -0500

    testsuite: Separate out Windows results for T5205
    
    This test seems to have much different allocation behavior on Windows
    and Linux.  Previously we had widened the acceptance window to 7% to
    accomodate this, but even this isn't enough any more. Instead of further
    widening the window let's just give an expected number for each
    platform. Really, this is precisely the issue with our performance
    testing model which I've been complaining about in #12758.
    
    Fixes test for #5205 on 64-bit Windows.
    
    Test Plan: Validate on Windows
    
    Reviewers: austin
    
    Subscribers: thomie, Phyx
    
    Differential Revision: https://phabricator.haskell.org/D2848
    
    GHC Trac Issues: #5205


>---------------------------------------------------------------

d39816285341cf639b51ae14f65c63a3e89bba95
 testsuite/tests/perf/should_run/all.T | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/testsuite/tests/perf/should_run/all.T b/testsuite/tests/perf/should_run/all.T
index da75f42..5e7e5cf 100644
--- a/testsuite/tests/perf/should_run/all.T
+++ b/testsuite/tests/perf/should_run/all.T
@@ -191,12 +191,17 @@ test('T5205',
      [stats_num_field('bytes allocated',
                       [(wordsize(32), 47088, 5),
                     # expected value: 47088 (x86/Darwin)
-                       (wordsize(64), 56208, 7)]),
+
+                       (platform('x86_64-unknown-mingw32'), 52264, 5),
+                    # 2016-12-14: 52264 (Separate out Windows results)
+
+                       (wordsize(64), 56208, 5)]),
                     # expected value: 51320 (amd64/Linux)
                     # 2014-07-17:     52600 (amd64/Linux) general round of updates
                     # 2015-04-03: Widen 5->7% (amd64/Windows was doing better)
                     # 2015-08-15: 50648 (Windows too good. avg of Windows&Linux)
                     # 2015-10-30: 56208 (D757: Emit Typeable at definition site)
+                    # 2016-12-14: Narrow 7->5% (Separate out Windows results)
       only_ways(['normal', 'optasm'])
       ],
      compile_and_run,



More information about the ghc-commits mailing list