[commit: ghc] master: Sanity check if we pick up an hsig file without -instantiated-with. (24f6bec)

git at git.haskell.org git at git.haskell.org
Tue Dec 13 07:11:57 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/24f6bec94411aa6c39a2c94ce5154ffe96ae330f/ghc

>---------------------------------------------------------------

commit 24f6bec94411aa6c39a2c94ce5154ffe96ae330f
Author: Edward Z. Yang <ezyang at cs.stanford.edu>
Date:   Thu Dec 8 19:32:37 2016 -0800

    Sanity check if we pick up an hsig file without -instantiated-with.
    
    Summary:
    Previously we would just let compilation proceed along until
    we tried to pull up the Module for the hsig file, and get
    main:A instead of <A>, and get a mysterious error.  Check
    for this earlier!
    
    Fixes #12955.
    
    Signed-off-by: Edward Z. Yang <ezyang at cs.stanford.edu>
    
    Test Plan: validate
    
    Reviewers: simonpj, austin, bgamari
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D2815
    
    GHC Trac Issues: #12955


>---------------------------------------------------------------

24f6bec94411aa6c39a2c94ce5154ffe96ae330f
 compiler/basicTypes/Module.hs                         | 15 ++-------------
 compiler/main/GhcMake.hs                              | 18 ++++++++++++++++++
 testsuite/tests/backpack/reexport/bkpreex02.stderr    |  8 ++++----
 testsuite/tests/backpack/should_compile/bkp24.stderr  |  4 ++--
 testsuite/tests/backpack/should_fail/bkpfail14.stderr |  2 +-
 testsuite/tests/backpack/should_fail/bkpfail15.stderr |  2 +-
 testsuite/tests/driver/Makefile                       |  5 +++++
 testsuite/tests/driver/T12955.hsig                    |  1 +
 testsuite/tests/driver/T12955.stderr                  |  9 +++++++++
 testsuite/tests/driver/all.T                          |  2 ++
 10 files changed, 45 insertions(+), 21 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 24f6bec94411aa6c39a2c94ce5154ffe96ae330f


More information about the ghc-commits mailing list