[commit: ghc] master: Reduce qualification in error messages from signature matching. (617d57d)

git at git.haskell.org git at git.haskell.org
Thu Dec 8 23:05:38 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/617d57d1166d67148f28401fabaf88295f1d3f06/ghc

>---------------------------------------------------------------

commit 617d57d1166d67148f28401fabaf88295f1d3f06
Author: Edward Z. Yang <ezyang at cs.stanford.edu>
Date:   Wed Dec 7 23:07:19 2016 -0800

    Reduce qualification in error messages from signature matching.
    
    Summary:
    Previously, we always qualified names, even if they were defined
    in the modules we were matching.  Adding the exports of the implementing
    module into the RdrEnv greatly reduces the amount of qualification
    (although we still can't qualify things that the signature *imported*.)
    
    Signed-off-by: Edward Z. Yang <ezyang at cs.stanford.edu>
    
    Test Plan: validate
    
    Reviewers: simonpj, austin, bgamari
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D2803


>---------------------------------------------------------------

617d57d1166d67148f28401fabaf88295f1d3f06
 compiler/typecheck/TcBackpack.hs                      |  7 +++++++
 testsuite/tests/backpack/should_fail/bkpfail06.stderr |  8 ++++----
 testsuite/tests/backpack/should_fail/bkpfail07.stderr |  8 ++++----
 testsuite/tests/backpack/should_fail/bkpfail10.stderr | 12 ++++++------
 testsuite/tests/backpack/should_fail/bkpfail11.stderr |  5 ++---
 testsuite/tests/backpack/should_fail/bkpfail12.stderr |  6 +++---
 testsuite/tests/backpack/should_fail/bkpfail13.stderr |  6 +++---
 testsuite/tests/backpack/should_fail/bkpfail14.stderr |  6 +++---
 testsuite/tests/backpack/should_fail/bkpfail15.stderr |  6 +++---
 testsuite/tests/backpack/should_fail/bkpfail17.stderr |  9 ++++-----
 testsuite/tests/backpack/should_fail/bkpfail22.stderr |  6 +++---
 testsuite/tests/backpack/should_fail/bkpfail23.stderr |  8 ++++----
 testsuite/tests/backpack/should_fail/bkpfail25.stderr |  6 +++---
 testsuite/tests/backpack/should_fail/bkpfail26.stderr |  6 +++---
 testsuite/tests/backpack/should_fail/bkpfail27.stderr |  6 +++---
 15 files changed, 55 insertions(+), 50 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 617d57d1166d67148f28401fabaf88295f1d3f06


More information about the ghc-commits mailing list