[commit: ghc] master: RnExpr: Fix ApplicativeDo desugaring with RebindableSyntax (043604c)

git at git.haskell.org git at git.haskell.org
Wed Aug 31 20:35:23 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/043604c7232adb698d5008a46d3f29d532acd12d/ghc

>---------------------------------------------------------------

commit 043604c7232adb698d5008a46d3f29d532acd12d
Author: Ben Gamari <bgamari.foss at gmail.com>
Date:   Wed Aug 31 16:03:33 2016 -0400

    RnExpr: Fix ApplicativeDo desugaring with RebindableSyntax
    
    We need to compare against the local return and pure, not returnMName
    and pureAName.
    
    Fixes #12490.
    
    Test Plan: Validate, add testcase
    
    Reviewers: austin, simonmar
    
    Reviewed By: simonmar
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D2499
    
    GHC Trac Issues: #12490


>---------------------------------------------------------------

043604c7232adb698d5008a46d3f29d532acd12d
 compiler/rename/RnEnv.hs      | 13 +++++++++-
 compiler/rename/RnExpr.hs     | 55 +++++++++++++++++++++++++++----------------
 testsuite/tests/ado/T12490.hs | 30 +++++++++++++++++++++++
 testsuite/tests/ado/all.T     |  1 +
 4 files changed, 78 insertions(+), 21 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 043604c7232adb698d5008a46d3f29d532acd12d


More information about the ghc-commits mailing list