[commit: ghc] master: Clarify comment on makeCorePair (a13fda7)
git at git.haskell.org
git at git.haskell.org
Wed Aug 3 16:06:54 UTC 2016
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/a13fda71b02cdaa840f8040b392777272a0d7794/ghc
>---------------------------------------------------------------
commit a13fda71b02cdaa840f8040b392777272a0d7794
Author: Matthew Pickering <matthewtpickering at gmail.com>
Date: Wed Aug 3 17:06:42 2016 +0100
Clarify comment on makeCorePair
>---------------------------------------------------------------
a13fda71b02cdaa840f8040b392777272a0d7794
compiler/deSugar/DsBinds.hs | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/compiler/deSugar/DsBinds.hs b/compiler/deSugar/DsBinds.hs
index f5211d2..8c05f43 100644
--- a/compiler/deSugar/DsBinds.hs
+++ b/compiler/deSugar/DsBinds.hs
@@ -349,9 +349,12 @@ dsHsBind _ (PatSynBind{}) = panic "dsHsBind: PatSynBind"
-- | This is where we apply INLINE and INLINABLE pragmas. All we need to
--- do is to attach the unfolding information to the Id. When the interface
--- files are created, unfoldings are only attached if the information is
--- present.
+-- do is to attach the unfolding information to the Id.
+--
+-- Other decisions about whether to inline are made in
+-- `calcUnfoldingGuidance` but the decision about whether to then expose
+-- the unfolding in the interface file is made in `TidyPgm.addExternal`
+-- using this information.
------------------------
makeCorePair :: DynFlags -> Id -> Bool -> Arity -> CoreExpr -> (Id, CoreExpr)
makeCorePair dflags gbl_id is_default_method dict_arity rhs
More information about the ghc-commits
mailing list