[commit: ghc] master: Change runtime linker to perform lazy loading of symbols/sections (90538d8)

Sun Apr 10 23:42:03 UTC 2016

Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/90538d86af579595987826cd893828d6f379f35a/ghc

>---------------------------------------------------------------

commit 90538d86af579595987826cd893828d6f379f35a
Author: Tamar Christina <tamar at zhox.com>
Date:   Mon Apr 11 00:38:42 2016 +0200

    Change runtime linker to perform lazy loading of symbols/sections

    The Runtime Linker is currently eagerly loading all object files on all
    platforms which do not use the system linker for `GHCi`.

    The problem with this approach is that it requires all symbols to be
    found.  Even those of functions never used/called. This makes the number
    of libraries required to link things like `mingwex` quite high.

    To work around this the `rts` was relying on a trick. It itself was
    compiled with `MingW64-w`'s `GCC`. So it was already linked against
    `mingwex`.  As such, it re-exported the symbols from itself.

    While this worked it made it impossible to link against `mingwex` in
    user libraries. And with this means no `C99` code could ever run in
    `GHCi` on Windows without having the required symbols re-exported from
    the rts.

    Consequently this rules out a large number of packages on Windows.
    SDL2, HMatrix etc.

    After talking with @rwbarton I have taken the approach of loading entire
    object files when a symbol is needed instead of doing the dependency
    tracking on a per symbol basis. This is a lot less fragile and a lot
    less complicated to implement.

    The changes come down to the following steps:

    1) modify the linker to and introduce a new state for ObjectCode:
       `Needed`.  A Needed object is one that is required for the linking to
       succeed.  The initial set consists of all Object files passed as
       arguments to the link.

    2) Change `ObjectCode`'s to be indexed but not initialized or resolved.
       This means we know where we would load the symbols,
       but haven't actually done so.

    3) Mark any `ObjectCode` belonging to `.o` passed as argument
       as required: ObjectState `NEEDED`.

    4) During `Resolve` object calls, mark all `ObjectCode`
       containing the required symbols as `NEEDED`

    5) During `lookupSymbol` lookups, (which is called from `linkExpr`
       and `linkDecl` in `GHCI.hs`) is the symbol is in a not-yet-loaded
       `ObjectCode` then load the `ObjectCode` on demand and return the
       address of the symbol. Otherwise produce an unresolved symbols error
       as expected.

    6) On `unloadObj` we then change the state of the object and remove
       it's symbols from the `reqSymHash` table so it can be reloaded.

    This change affects all platforms and OSes which use the runtime linker.
    It seems there are no real perf tests for `GHCi`, but performance
    shouldn't be impacted much. We gain a lot of time not loading all `obj`
    files, and we lose some time in `lookupSymbol` when we're finding
    sections that have to be loaded. The actual finding itself is O(1)
    (Assuming the hashtnl is perfect)

    It also consumes slighly more memory as instead of storing just the
    address of a symbol I also store some other information, like if the
    symbol is weak or not.

    This change will break any packages relying on renamed POSIX functions
    that were re-named and re-exported by the rts. Any packages following
    the proper naming for functions as found on MSDN will work fine.

    Test Plan: ./validate on all platforms which use the Runtime linker.

    Reviewers: thomie, rwbarton, simonmar, erikd, bgamari, austin, hvr

    Reviewed By: erikd

    Subscribers: kgardas, gridaphobe, RyanGlScott, simonmar,
                 rwbarton, #ghc_windows_task_force

    Differential Revision: https://phabricator.haskell.org/D1805

    GHC Trac Issues: #11223

>---------------------------------------------------------------

90538d86af579595987826cd893828d6f379f35a
 compiler/main/SysTools.hs                          |  19 +-
 configure.ac                                       |   3 -
 docs/users_guide/8.0.1-notes.rst                   |   9 +
 libraries/base/System/Posix/Internals.hs           | 131 ++++--
 libraries/base/base.cabal                          |  10 +-
 libraries/base/include/HsBase.h                    |   2 +-
 libraries/ghc-prim/ghc-prim.cabal                  |  14 +
 rts/Linker.c                                       | 445 ++++++++++++++++-----
 rts/LinkerInternals.h                              |  23 +-
 rts/RtsSymbols.c                                   | 319 +--------------
 testsuite/tests/ghci/linking/dyn/all.T             |   2 +-
 testsuite/tests/rts/T11223/Makefile                | 126 ++++++
 .../rts/T11223/T11223_link_order_a_b_2_fail.stderr |  25 ++
 .../T11223_link_order_a_b_2_fail.stderr-mingw32    |  25 ++
 .../T11223/T11223_link_order_a_b_succeed.stdout    |   1 +
 .../T11223/T11223_link_order_b_a_2_succeed.stdout  |   1 +
 .../T11223/T11223_link_order_b_a_succeed.stdout    |   1 +
 .../rts/T11223/T11223_simple_duplicate_lib.stderr  |  25 ++
 .../T11223_simple_duplicate_lib.stderr-mingw32     |  25 ++
 ..._simple_duplicate_lib.stderr.normalised-mingw32 |  24 ++
 .../tests/rts/T11223/T11223_simple_link.stdout     |   1 +
 .../tests/rts/T11223/T11223_simple_link_lib.stdout |   1 +
 .../T11223_simple_unused_duplicate_lib.stdout      |   1 +
 testsuite/tests/rts/T11223/all.T                   |  93 +++++
 testsuite/tests/rts/T11223/bar.c                   |   4 +
 testsuite/tests/rts/T11223/foo.c                   |  14 +
 testsuite/tests/rts/T11223/foo.hs                  |   5 +
 testsuite/tests/rts/T11223/foo2.hs                 |   5 +
 testsuite/tests/rts/T11223/foo3.hs                 |   6 +
 testsuite/tests/rts/T11223/power.c                 |  10 +
 testsuite/tests/rts/T11223/power.hs                |   5 +
 testsuite/tests/rts/T11223/power3.hs               |   5 +
 testsuite/tests/rts/T11223/power_slow.c            |  14 +
 33 files changed, 943 insertions(+), 451 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 90538d86af579595987826cd893828d6f379f35a