[commit: ghc] master: Fix misattribution of `-Wunused-local-binds` warnings (1e6ec12)

git at git.haskell.org git at git.haskell.org
Tue Apr 5 13:44:30 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/1e6ec1249b4da88fec9024598c2183e6fc0e96cd/ghc

>---------------------------------------------------------------

commit 1e6ec1249b4da88fec9024598c2183e6fc0e96cd
Author: Herbert Valerio Riedel <hvr at gnu.org>
Date:   Tue Apr 5 15:15:47 2016 +0200

    Fix misattribution of `-Wunused-local-binds` warnings
    
    This fixes a bug where warnings actually controlled by
    
    - `Opt_WarnUnusedMatches`
    - `Opt_WarnUnusedTypePatterns`
    - `Opt_WarnUnusedTopBinds`
    
    were incorrectly reported as being controlled by
    `Opt_WarnUnusedLocalBinds` as well
    
    This bug was introduced in bb5afd3c274011c5ea302210b4c290ec1f83209c
    while implementing #10752
    
    Test Plan: ./validate still running -- testsuite output wiggles expected
    
    Reviewers: barrucadu, quchen, austin, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D2077


>---------------------------------------------------------------

1e6ec1249b4da88fec9024598c2183e6fc0e96cd
 compiler/rename/RnEnv.hs                                | 17 +++++++++--------
 testsuite/tests/deSugar/should_compile/ds053.stderr     |  2 +-
 testsuite/tests/driver/werror.stderr                    |  2 +-
 .../should_compile/UnusedTyVarWarnings.stderr           |  8 ++++----
 .../should_compile/UnusedTyVarWarningsNamedWCs.stderr   |  8 ++++----
 .../should_fail/overloadedrecfldsfail05.stderr          |  2 +-
 .../should_fail/overloadedrecfldsfail06.stderr          |  6 +++---
 testsuite/tests/parser/should_compile/read014.stderr    |  4 ++--
 testsuite/tests/rename/should_compile/T17a.stderr       |  2 +-
 testsuite/tests/rename/should_compile/T17d.stderr       |  2 +-
 testsuite/tests/rename/should_compile/T17e.stderr       |  2 +-
 testsuite/tests/rename/should_compile/T3371.stderr      |  2 +-
 testsuite/tests/rename/should_compile/T3449.stderr      |  2 +-
 testsuite/tests/rename/should_compile/T7145b.stderr     |  2 +-
 testsuite/tests/rename/should_compile/mc10.stderr       |  2 +-
 testsuite/tests/rename/should_compile/rn040.stderr      |  4 ++--
 testsuite/tests/rename/should_compile/rn041.stderr      |  6 +++---
 testsuite/tests/rename/should_compile/rn047.stderr      |  2 +-
 testsuite/tests/typecheck/should_compile/T2497.stderr   |  2 +-
 19 files changed, 39 insertions(+), 38 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 1e6ec1249b4da88fec9024598c2183e6fc0e96cd


More information about the ghc-commits mailing list