[commit: ghc] wip/rae: Perform a validity check on assoc type defaults. (51c7306)
git at git.haskell.org
git at git.haskell.org
Mon Sep 21 01:50:39 UTC 2015
Repository : ssh://git@git.haskell.org/ghc
On branch : wip/rae
Link : http://ghc.haskell.org/trac/ghc/changeset/51c73064d4eb2eec4bfebcdc4228c740038213b8/ghc
>---------------------------------------------------------------
commit 51c73064d4eb2eec4bfebcdc4228c740038213b8
Author: Richard Eisenberg <eir at cis.upenn.edu>
Date: Sat Sep 19 14:32:44 2015 -0400
Perform a validity check on assoc type defaults.
This fixes #10817 and #10899. A knock-on effect is that we must
now remember locations of associated type defaults for error
messages during validity checking. This isn't too bad, but it
increases the size of the diff somewhat.
Test cases: indexed-types/should_fail/T108{17,99}
>---------------------------------------------------------------
51c73064d4eb2eec4bfebcdc4228c740038213b8
compiler/iface/MkIface.hs | 2 +-
compiler/iface/TcIface.hs | 2 +-
compiler/typecheck/TcInstDcls.hs | 7 +++++-
compiler/typecheck/TcRnDriver.hs | 4 ++--
compiler/typecheck/TcTyClsDecls.hs | 26 +++++++++++++---------
compiler/typecheck/TcValidity.hs | 17 +++++++++++++-
compiler/types/Class.hs | 6 ++++-
.../tests/indexed-types/should_fail/T10817.hs | 14 ++++++++++++
.../tests/indexed-types/should_fail/T10817.stderr | 6 +++++
.../tests/indexed-types/should_fail/T10899.hs | 7 ++++++
.../tests/indexed-types/should_fail/T10899.stderr | 4 ++++
testsuite/tests/indexed-types/should_fail/all.T | 2 ++
testsuite/tests/typecheck/should_compile/tc253.hs | 2 ++
13 files changed, 82 insertions(+), 17 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 51c73064d4eb2eec4bfebcdc4228c740038213b8
More information about the ghc-commits
mailing list