[commit: ghc] master: Suggest chmod 755 instead of 644 (0ae6a43)
git at git.haskell.org
git at git.haskell.org
Thu Oct 22 15:32:52 UTC 2015
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/0ae6a43ebccca65c3a6b6172e0513802d303e84e/ghc
>---------------------------------------------------------------
commit 0ae6a43ebccca65c3a6b6172e0513802d303e84e
Author: Ben Gamari <bgamari.foss at gmail.com>
Date: Thu Oct 22 17:35:18 2015 +0200
Suggest chmod 755 instead of 644
Previous suggestion would clear executable bit, meaning directory
couldn't be entered. Fixes #11003.
Test Plan: Read message.
Reviewers: austin, thomie, dfeuer
Reviewed By: thomie, dfeuer
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D1350
GHC Trac Issues: #11003
>---------------------------------------------------------------
0ae6a43ebccca65c3a6b6172e0513802d303e84e
ghc/InteractiveUI.hs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ghc/InteractiveUI.hs b/ghc/InteractiveUI.hs
index f3d2035..736b8a9 100644
--- a/ghc/InteractiveUI.hs
+++ b/ghc/InteractiveUI.hs
@@ -630,7 +630,7 @@ checkPerms file =
-- #8248: Improving warning to include a possible fix.
putStrLn $ "*** WARNING: " ++ file ++
" is writable by someone else, IGNORING!" ++
- "\nSuggested fix: execute 'chmod 644 " ++ file ++ "'"
+ "\nSuggested fix: execute 'chmod go-w " ++ file ++ "'"
return ok
#endif
More information about the ghc-commits
mailing list