[commit: ghc] master: Move orphan instance/rule warnings to typechecker/desugarer. (931d0a7)
git at git.haskell.org
git at git.haskell.org
Fri Oct 9 00:32:16 UTC 2015
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/931d0a7d1cd296f8c2a6190a06a2d3dcc8996ac3/ghc
>---------------------------------------------------------------
commit 931d0a7d1cd296f8c2a6190a06a2d3dcc8996ac3
Author: Edward Z. Yang <ezyang at cs.stanford.edu>
Date: Thu Oct 1 15:24:41 2015 -0700
Move orphan instance/rule warnings to typechecker/desugarer.
Summary:
Instead of doing these warnings at MkIface time, we do them
when we create the instances/rules in the typechecker/desugarer.
Emitting warnings for auto-generated instances was a pain
(since the specialization monad doesn't have the capacity
to emit warnings) so instead I just deprecated -fwarn-auto-orphans.
Auto rule orphans are pretty harmless anyway: they don't cause
interface files to be eagerly loaded in.
Signed-off-by: Edward Z. Yang <ezyang at cs.stanford.edu>
Test Plan: validate
Reviewers: simonpj, austin, bgamari
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D1297
>---------------------------------------------------------------
931d0a7d1cd296f8c2a6190a06a2d3dcc8996ac3
compiler/deSugar/Desugar.hs | 6 +-
compiler/deSugar/DsBinds.hs | 17 +++-
compiler/iface/MkIface.hs | 93 ++++------------------
compiler/main/DynFlags.hs | 3 +-
compiler/main/HscMain.hs | 6 +-
compiler/specialise/Specialise.hs | 20 +++++
compiler/typecheck/Inst.hs | 16 +++-
compiler/typecheck/TcGenGenerics.hs | 23 +++---
compiler/types/InstEnv.hs | 4 +-
docs/users_guide/using-warnings.rst | 10 +--
.../tests/typecheck/should_compile/T4912.stderr | 8 +-
.../tests/warnings/should_compile/T9178.stderr | 4 +-
utils/mkUserGuidePart/Options/Warnings.hs | 4 +-
13 files changed, 96 insertions(+), 118 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 931d0a7d1cd296f8c2a6190a06a2d3dcc8996ac3
More information about the ghc-commits
mailing list