[commit: ghc] master: ApiAnnotations: BooleanFormula is not properly Located (f16827f)

git at git.haskell.org git at git.haskell.org
Sun Nov 1 12:43:00 UTC 2015


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/f16827f84855bef94b1b69f49bd1734627946f02/ghc

>---------------------------------------------------------------

commit f16827f84855bef94b1b69f49bd1734627946f02
Author: Alan Zimmerman <alan.zimm at gmail.com>
Date:   Sun Nov 1 11:13:21 2015 +0100

    ApiAnnotations: BooleanFormula is not properly Located
    
    At the moment BooleanFormula is defined as
    
      data BooleanFormula a = Var a | And [BooleanFormula a]
                            | Or [BooleanFormula a]
           deriving (Eq, Data, Typeable, Functor, Foldable, Traversable)
    
    An API Annotation can only be attached to an item of the form Located a.
    
    Replace this with a properly Located version, and attach the appropriate
    API Annotations to it
    
    Updates haddock submodule.
    
    Test Plan: ./validate
    
    Reviewers: austin, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: thomie, mpickering
    
    Differential Revision: https://phabricator.haskell.org/D1384
    
    GHC Trac Issues: #11017


>---------------------------------------------------------------

f16827f84855bef94b1b69f49bd1734627946f02
 compiler/hsSyn/HsBinds.hs                          |  8 +--
 compiler/parser/Parser.y                           | 27 +++++----
 compiler/rename/RnBinds.hs                         |  4 +-
 compiler/typecheck/TcClassDcl.hs                   |  6 +-
 compiler/utils/BooleanFormula.hs                   | 67 +++++++++++++---------
 .../tests/ghc-api/annotations/boolFormula.stdout   | 31 ++++++----
 utils/haddock                                      |  2 +-
 7 files changed, 82 insertions(+), 63 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc f16827f84855bef94b1b69f49bd1734627946f02


More information about the ghc-commits mailing list