[commit: ghc] master: Remove some unimplemented GranSim primops (90dd11b)

git at git.haskell.org git at git.haskell.org
Fri Mar 27 15:26:23 UTC 2015


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/90dd11bf1918485f0f19bb2fb764f1675c0f0dd5/ghc

>---------------------------------------------------------------

commit 90dd11bf1918485f0f19bb2fb764f1675c0f0dd5
Author: Reid Barton <rwbarton at gmail.com>
Date:   Fri Mar 27 11:25:19 2015 -0400

    Remove some unimplemented GranSim primops
    
    Summary:
    An attempt to use these resulted in an error like:
    
    [1 of 1] Compiling Main             ( p.hs, p.o )
    ghc: panic! (the 'impossible' happened)
      (GHC version 7.8.4 for x86_64-unknown-linux):
    	emitPrimOp: can't translate PrimOp  parAt#{v}
    
    Test Plan: validate
    
    Reviewers: thomie, austin
    
    Reviewed By: thomie, austin
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D758


>---------------------------------------------------------------

90dd11bf1918485f0f19bb2fb764f1675c0f0dd5
 compiler/prelude/PrimOp.hs      |  6 -----
 compiler/prelude/primops.txt.pp | 49 -----------------------------------------
 2 files changed, 55 deletions(-)

diff --git a/compiler/prelude/PrimOp.hs b/compiler/prelude/PrimOp.hs
index 1c9b49e..de6d49b 100644
--- a/compiler/prelude/PrimOp.hs
+++ b/compiler/prelude/PrimOp.hs
@@ -278,12 +278,6 @@ Invariants:
             stable name.
 
 
--- HWL: The first 4 Int# in all par... annotations denote:
---   name, granularity info, size of result, degree of parallelism
---      Same  structure as _seq_ i.e. returns Int#
--- KSW: v, the second arg in parAt# and parAtForNow#, is used only to determine
---   `the processor containing the expression v'; it is not evaluated
-
 These primops are pretty weird.
 
         dataToTag# :: a -> Int    (arg must be an evaluated data type)
diff --git a/compiler/prelude/primops.txt.pp b/compiler/prelude/primops.txt.pp
index 909b17b..162063e 100644
--- a/compiler/prelude/primops.txt.pp
+++ b/compiler/prelude/primops.txt.pp
@@ -2421,55 +2421,6 @@ primop NumSparks "numSparks#" GenPrimOp
    has_side_effects = True
    out_of_line = True
 
--- HWL: The first 4 Int# in all par... annotations denote:
---   name, granularity info, size of result, degree of parallelism
---      Same  structure as _seq_ i.e. returns Int#
--- KSW: v, the second arg in parAt# and parAtForNow#, is used only to determine
---   `the processor containing the expression v'; it is not evaluated
-
-primop  ParGlobalOp  "parGlobal#"  GenPrimOp
-   a -> Int# -> Int# -> Int# -> Int# -> b -> Int#
-   with
-   has_side_effects = True
-
-primop  ParLocalOp  "parLocal#"  GenPrimOp
-   a -> Int# -> Int# -> Int# -> Int# -> b -> Int#
-   with
-   has_side_effects = True
-
-primop  ParAtOp  "parAt#"  GenPrimOp
-   b -> a -> Int# -> Int# -> Int# -> Int# -> c -> Int#
-   with
-   has_side_effects = True
-
-primop  ParAtAbsOp  "parAtAbs#"  GenPrimOp
-   a -> Int# -> Int# -> Int# -> Int# -> Int# -> b -> Int#
-   with
-   has_side_effects = True
-
-primop  ParAtRelOp  "parAtRel#" GenPrimOp
-   a -> Int# -> Int# -> Int# -> Int# -> Int# -> b -> Int#
-   with
-   has_side_effects = True
-
-primop  ParAtForNowOp  "parAtForNow#" GenPrimOp
-   b -> a -> Int# -> Int# -> Int# -> Int# -> c -> Int#
-   with
-   has_side_effects = True
-
--- copyable# and noFollow# are yet to be implemented (for GpH)
---
---primop  CopyableOp  "copyable#" GenPrimOp
---   a -> Int#
---   with
---   has_side_effects = True
---
---primop  NoFollowOp "noFollow#" GenPrimOp
---   a -> Int#
---   with
---   has_side_effects = True
-
-
 ------------------------------------------------------------------------
 section "Tag to enum stuff"
         {Convert back and forth between values of enumerated types



More information about the ghc-commits mailing list