[commit: ghc] wip/T10137: CmmSwitch: Avoid a -1 for jump tables (01164fc)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/T10137
Link       : http://ghc.haskell.org/trac/ghc/changeset/01164fc91f00245b3c946840027532a1b2c17a22/ghc

>---------------------------------------------------------------

commit 01164fc91f00245b3c946840027532a1b2c17a22
Author: Joachim Breitner <mail at joachim-breitner.de>
Date:   Mon Mar 16 21:10:59 2015 +0100

    CmmSwitch: Avoid a -1 for jump tables


>---------------------------------------------------------------

01164fc91f00245b3c946840027532a1b2c17a22
 compiler/cmm/CmmSwitch.hs | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/compiler/cmm/CmmSwitch.hs b/compiler/cmm/CmmSwitch.hs
index 60fa8ed..b062964 100644
--- a/compiler/cmm/CmmSwitch.hs
+++ b/compiler/cmm/CmmSwitch.hs
@@ -127,10 +127,37 @@ switchTargetsToTable :: SwitchTargets -> (Int, [Maybe Label])
 switchTargetsToTable (SwitchTargets _ Nothing _mbdef _branches)
     = pprPanic "switchTargetsToTable" empty
 switchTargetsToTable (SwitchTargets _ (Just (lo,hi)) mbdef branches)
-    = (fromIntegral (-lo), [ labelFor i | i <- [lo..hi] ])
+    = (fromIntegral (-start), [ labelFor i | i <- [start..hi] ])
   where
     labelFor i = case M.lookup i branches of Just l -> Just l
                                              Nothing -> mbdef
+    start | lo >= 0 && lo < 2 = 0  -- See Note [Jump Table Offset]
+          | otherwise         = lo
+
+-- Note [Jump Table Offset]
+-- ~~~~~~~~~~~~~~~~~~~~~~~~
+--
+-- Usually, the code for a jump table starting at x will first subtract x from
+-- the value, to avoid a large amount of empty entries. But if x is very small,
+-- the extra entries are no worse than the subtraction in terms of code size, and
+-- not having to do the subtraction is quicker.
+--
+-- I.e. instead of
+--     _u20N:
+--             leaq -1(%r14),%rax
+--             jmp *_n20R(,%rax,8)
+--     _n20R:
+--             .quad   _c20p
+--             .quad   _c20q
+-- do
+--     _u20N:
+--             jmp *_n20Q(,%r14,8)
+--
+--     _n20Q:
+--             .quad   0
+--             .quad   _c20p
+--             .quad   _c20q
+--             .quad   _c20r
 
 switchTargetsToList :: SwitchTargets -> [Label]
 switchTargetsToList (SwitchTargets _ _ mbdef branches)