[commit: haddock] master: Disable generating hyperlinks for module references. (98cb99c)

git at git.haskell.org git at git.haskell.org
Wed Jul 8 08:40:54 UTC 2015


Repository : ssh://git@git.haskell.org/haddock

On branch  : master
Link       : http://git.haskell.org/haddock.git/commitdiff/98cb99c2398a2e2b4467da0a1755d24422384f14

>---------------------------------------------------------------

commit 98cb99c2398a2e2b4467da0a1755d24422384f14
Author: Łukasz Hanuszczak <lukasz.hanuszczak at gmail.com>
Date:   Sun Jun 28 21:33:03 2015 +0200

    Disable generating hyperlinks for module references.


>---------------------------------------------------------------

98cb99c2398a2e2b4467da0a1755d24422384f14
 haddock-api/src/Haddock/Backends/Hyperlinker/Renderer.hs | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/haddock-api/src/Haddock/Backends/Hyperlinker/Renderer.hs b/haddock-api/src/Haddock/Backends/Hyperlinker/Renderer.hs
index b05a5b8..89d9b60 100644
--- a/haddock-api/src/Haddock/Backends/Hyperlinker/Renderer.hs
+++ b/haddock-api/src/Haddock/Backends/Hyperlinker/Renderer.hs
@@ -123,6 +123,13 @@ externalNameHyperlink pkg srcs name content
     mdl = GHC.nameModule name
     namePkg = GHC.modulePackageKey mdl
 
+-- TODO: Implement module hyperlinks.
+--
+-- Unfortunately, 'ModuleName' is not enough to provide viable cross-package
+-- hyperlink. And the problem is that GHC AST does not have other information
+-- on imported modules, so for the time being, we do not provide such reference
+-- either.
 externalModHyperlink :: GHC.ModuleName -> Html -> Html
-externalModHyperlink mdl content =
-    Html.anchor content ! [ Html.href $ hypSrcModuleUrl' mdl ]
+externalModHyperlink _ content =
+    content
+    --Html.anchor content ! [ Html.href $ hypSrcModuleUrl' mdl ]



More information about the ghc-commits mailing list