[commit: ghc] wip/redundant-constraints: Error message wibbles following -fwarn-redundant-constraints (02ddcd2)

git at git.haskell.org git at git.haskell.org
Mon Jan 5 15:01:37 UTC 2015


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/redundant-constraints
Link       : http://ghc.haskell.org/trac/ghc/changeset/02ddcd2ebab4d4f137941413c13f9ddc9cdae534/ghc

>---------------------------------------------------------------

commit 02ddcd2ebab4d4f137941413c13f9ddc9cdae534
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date:   Mon Jan 5 13:26:05 2015 +0000

    Error message wibbles following -fwarn-redundant-constraints
    
    Lots of small changes:
    
    * Many tests deliberately have functions like
        foo :: Eq a => blah
        foo = error "urk"
      and that (rightly) gives a redundant-constraint warning.
      So I add {-# OPTIONS -fno-warn-redundant-constraints #-} to all those tests
    
      That in turn changes the line number of error message for the test
    
    * A few tests had unnecessary redundant constraints; I removed them
    
    * Small change to error message for superclasses
    
    * One change (tcfail143) in which error is reported, when there is
      more than one on the same line


>---------------------------------------------------------------

02ddcd2ebab4d4f137941413c13f9ddc9cdae534
 testsuite/tests/arrows/should_compile/arrowpat.hs    |  3 ++-
 testsuite/tests/codeGen/should_compile/T3286.hs      |  1 +
 testsuite/tests/deriving/should_compile/T2856.hs     |  1 +
 testsuite/tests/deriving/should_compile/T4966.hs     |  2 ++
 testsuite/tests/deriving/should_compile/T4966.stderr |  4 ++--
 .../tests/deriving/should_compile/deriving-1935.hs   |  2 ++
 .../deriving/should_compile/deriving-1935.stderr     |  6 +++---
 testsuite/tests/deriving/should_compile/drv001.hs    |  2 ++
 testsuite/tests/deriving/should_compile/drv002.hs    |  2 ++
 testsuite/tests/deriving/should_compile/drv003.hs    |  2 ++
 .../tests/deriving/should_compile/drv003.stderr      |  4 ++--
 testsuite/tests/deriving/should_run/T9576.stderr     |  2 +-
 testsuite/tests/gadt/Gadt17_help.hs                  |  2 +-
 testsuite/tests/ghci/scripts/T5045.hs                |  1 +
 testsuite/tests/ghci/scripts/T8357.hs                |  1 +
 testsuite/tests/ghci/scripts/T8931.script            |  1 +
 testsuite/tests/ghci/scripts/ghci044.script          |  1 +
 testsuite/tests/ghci/scripts/ghci044.stderr          |  6 +++---
 testsuite/tests/ghci/scripts/ghci047.script          |  1 +
 testsuite/tests/ghci/scripts/ghci047.stderr          |  4 ++--
 testsuite/tests/haddock/haddock_examples/Test.hs     |  1 +
 .../haddock/haddock_examples/haddock.Test.stderr     |  8 ++++----
 .../should_compile_flag_haddock/haddockA023.hs       |  2 ++
 .../should_compile_flag_haddock/haddockA026.hs       |  2 ++
 .../should_compile_flag_haddock/haddockA027.hs       |  2 ++
 .../should_compile_noflag_haddock/haddockC026.hs     |  2 ++
 .../should_compile_noflag_haddock/haddockC027.hs     |  2 ++
 .../tests/indexed-types/should_compile/Class2.hs     |  1 +
 .../tests/indexed-types/should_compile/Gentle.hs     |  1 +
 .../indexed-types/should_compile/InstContextNorm.hs  |  1 +
 .../indexed-types/should_compile/InstEqContext.hs    |  1 +
 .../indexed-types/should_compile/InstEqContext2.hs   |  1 +
 .../indexed-types/should_compile/InstEqContext3.hs   |  1 +
 .../indexed-types/should_compile/NonLinearLHS.hs     |  1 +
 .../tests/indexed-types/should_compile/Rules1.hs     |  1 +
 .../tests/indexed-types/should_compile/Simple24.hs   |  1 +
 .../tests/indexed-types/should_compile/T2448.hs      |  1 +
 .../tests/indexed-types/should_compile/T3023.hs      |  3 ++-
 .../tests/indexed-types/should_compile/T3023.stderr  |  5 ++---
 .../tests/indexed-types/should_compile/T3484.hs      |  3 ++-
 .../tests/indexed-types/should_compile/T4200.hs      |  1 +
 .../tests/indexed-types/should_compile/T4497.hs      |  1 +
 .../tests/indexed-types/should_compile/T4981-V1.hs   |  2 ++
 .../tests/indexed-types/should_compile/T4981-V2.hs   |  2 ++
 .../tests/indexed-types/should_compile/T4981-V3.hs   |  2 ++
 .../tests/indexed-types/should_compile/T5002.hs      |  1 +
 .../tests/indexed-types/should_compile/T9090.hs      |  2 ++
 .../tests/indexed-types/should_compile/T9316.hs      |  1 +
 .../tests/indexed-types/should_compile/T9747.hs      |  2 ++
 testsuite/tests/indexed-types/should_fail/T2239.hs   |  1 +
 .../tests/indexed-types/should_fail/T3330c.stderr    |  4 ++++
 testsuite/tests/indexed-types/should_fail/T7862.hs   |  1 +
 .../tests/indexed-types/should_fail/T7862.stderr     |  2 +-
 testsuite/tests/module/mod129.hs                     |  2 ++
 testsuite/tests/module/mod71.stderr                  |  9 +++++++++
 testsuite/tests/parser/should_compile/mc15.hs        |  2 +-
 testsuite/tests/parser/should_compile/read002.hs     |  2 ++
 testsuite/tests/partial-sigs/should_compile/all.T    |  2 +-
 testsuite/tests/patsyn/should_compile/T8584-2.hs     |  2 ++
 testsuite/tests/patsyn/should_compile/T8968-1.hs     |  1 +
 testsuite/tests/patsyn/should_compile/all.T          |  4 ++--
 testsuite/tests/patsyn/should_compile/ex-view.hs     |  4 +++-
 testsuite/tests/perf/compiler/T3064.hs               |  2 ++
 testsuite/tests/perf/compiler/T5030.hs               |  6 +++---
 testsuite/tests/polykinds/PolyKinds08.hs             |  1 +
 testsuite/tests/polykinds/T6015a.hs                  |  1 +
 testsuite/tests/polykinds/T6020a.hs                  |  1 +
 testsuite/tests/polykinds/T6068.hs                   |  1 +
 testsuite/tests/polykinds/T7090.hs                   |  1 +
 testsuite/tests/polykinds/T7332.hs                   | 20 ++++++++++++++++++--
 testsuite/tests/polykinds/T8359.hs                   |  2 ++
 testsuite/tests/polykinds/T9569.hs                   |  1 +
 testsuite/tests/polykinds/T9750.hs                   |  1 +
 testsuite/tests/rebindable/T5821.hs                  |  3 ++-
 testsuite/tests/rebindable/rebindable9.hs            |  4 ++--
 testsuite/tests/rename/should_fail/rnfail020.hs      |  1 +
 testsuite/tests/simplCore/should_compile/T3831.hs    |  1 +
 testsuite/tests/simplCore/should_compile/T4398.hs    |  1 +
 .../tests/simplCore/should_compile/T4398.stderr      |  2 +-
 testsuite/tests/simplCore/should_compile/T5329.hs    |  1 +
 testsuite/tests/simplCore/should_compile/T5342.hs    |  1 +
 testsuite/tests/simplCore/should_compile/T5359b.hs   |  1 +
 .../tests/simplCore/should_compile/T5359b.stderr     |  2 +-
 testsuite/tests/simplCore/should_compile/T8848.hs    |  3 ++-
 .../tests/simplCore/should_compile/T8848.stderr      |  2 +-
 testsuite/tests/simplCore/should_compile/T8848a.hs   |  1 +
 testsuite/tests/simplCore/should_compile/simpl002.hs |  2 ++
 testsuite/tests/simplCore/should_compile/simpl007.hs |  1 +
 testsuite/tests/simplCore/should_compile/simpl014.hs |  1 +
 testsuite/tests/simplCore/should_compile/simpl016.hs |  2 ++
 .../tests/simplCore/should_compile/simpl016.stderr   |  2 +-
 testsuite/tests/simplCore/should_compile/spec003.hs  |  2 ++
 testsuite/tests/th/T3100.hs                          |  1 +
 testsuite/tests/th/T7021a.hs                         |  1 +
 testsuite/tests/th/T8807.hs                          |  1 +
 testsuite/tests/th/TH_tf3.hs                         |  1 +
 .../typecheck/should_compile/GivenOverlapping.hs     |  1 +
 .../tests/typecheck/should_compile/LoopOfTheDay1.hs  |  1 +
 .../tests/typecheck/should_compile/LoopOfTheDay2.hs  |  1 +
 .../tests/typecheck/should_compile/LoopOfTheDay3.hs  |  1 +
 testsuite/tests/typecheck/should_compile/T1470.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T2683.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T3018.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T3108.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T3692.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T3743.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T4361.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T4401.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T4524.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T4952.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T4969.hs    |  2 +-
 testsuite/tests/typecheck/should_compile/T5514.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T5581.hs    |  2 ++
 testsuite/tests/typecheck/should_compile/T5676.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T6055.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T6134.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T7171a.hs   |  1 +
 testsuite/tests/typecheck/should_compile/T7196.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T7220.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T7541.hs    |  2 +-
 testsuite/tests/typecheck/should_compile/T7875.hs    |  1 +
 testsuite/tests/typecheck/should_compile/T7903.hs    |  1 +
 .../tests/typecheck/should_compile/T7903.stderr-ghc  |  4 ++--
 .../tests/typecheck/should_compile/Tc170_Aux.hs      |  1 +
 testsuite/tests/typecheck/should_compile/Tc173a.hs   |  2 ++
 testsuite/tests/typecheck/should_compile/tc045.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc051.hs    |  2 ++
 .../tests/typecheck/should_compile/tc056.stderr      |  6 ++----
 testsuite/tests/typecheck/should_compile/tc058.hs    |  2 ++
 testsuite/tests/typecheck/should_compile/tc065.hs    |  4 ++--
 testsuite/tests/typecheck/should_compile/tc078.hs    |  2 ++
 .../tests/typecheck/should_compile/tc078.stderr-ghc  |  4 ++--
 testsuite/tests/typecheck/should_compile/tc079.hs    |  2 ++
 testsuite/tests/typecheck/should_compile/tc088.hs    |  2 ++
 testsuite/tests/typecheck/should_compile/tc091.hs    |  2 ++
 testsuite/tests/typecheck/should_compile/tc092.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc109.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc113.hs    |  2 ++
 testsuite/tests/typecheck/should_compile/tc115.hs    |  1 +
 .../tests/typecheck/should_compile/tc115.stderr-ghc  |  2 +-
 testsuite/tests/typecheck/should_compile/tc116.hs    |  1 +
 .../tests/typecheck/should_compile/tc116.stderr-ghc  |  2 +-
 testsuite/tests/typecheck/should_compile/tc125.hs    |  1 +
 .../tests/typecheck/should_compile/tc125.stderr-ghc  | 10 +++++-----
 testsuite/tests/typecheck/should_compile/tc126.hs    |  1 +
 .../tests/typecheck/should_compile/tc126.stderr-ghc  |  4 ++--
 testsuite/tests/typecheck/should_compile/tc145.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc152.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc176.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc178.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc180.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc181.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc183.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc187.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc192.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc203.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc204.hs    |  3 ++-
 testsuite/tests/typecheck/should_compile/tc206.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc208.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc229.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc230.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc235.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc237.hs    |  1 +
 testsuite/tests/typecheck/should_compile/tc239.hs    |  1 +
 testsuite/tests/typecheck/should_compile/twins.hs    |  1 +
 testsuite/tests/typecheck/should_fail/T6161.stderr   |  4 +++-
 .../tests/typecheck/should_fail/tcfail017.stderr     |  4 +++-
 .../tests/typecheck/should_fail/tcfail020.stderr     |  4 +++-
 testsuite/tests/typecheck/should_fail/tcfail071.hs   |  2 ++
 testsuite/tests/typecheck/should_fail/tcfail138.hs   |  1 +
 .../tests/typecheck/should_fail/tcfail143.stderr     |  4 ++--
 171 files changed, 271 insertions(+), 70 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 02ddcd2ebab4d4f137941413c13f9ddc9cdae534


More information about the ghc-commits mailing list