[commit: ghc] master: Refactor decideQuantification (b96db75)

Fri Feb 13 23:08:55 UTC 2015

Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/b96db75c2ea3ea5756dac7d67ca366dab61bafa7/ghc

>---------------------------------------------------------------

commit b96db75c2ea3ea5756dac7d67ca366dab61bafa7
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date:   Fri Feb 13 23:09:34 2015 +0000

    Refactor decideQuantification

    Richard was interrogating me about decideQuantification yesterday.
    I got a bit stuck on the promote_tvs part. This refactoring

     * simplifes the API of decideQuantification

     * move mkMinimalBySCs into decideQuantification (a better place for it)

     * moves promotion out of decideQuantification (where it didn't really
       fit), and comments much more fully what is going on with the promtion stuff

     * comments decideQuantification more fully

     * coments the EqPred case of quantifyPred more fully

    It turned out that the theta returned by decideQuantification,
    and hence by simplifyInfer, is now fully zonked, so I could remove
    a zonking in TcBinds.

>---------------------------------------------------------------

b96db75c2ea3ea5756dac7d67ca366dab61bafa7
 compiler/typecheck/TcBinds.hs                      |   2 +-
 compiler/typecheck/TcSimplify.hs                   | 133 +++++++++++++--------
 .../tests/indexed-types/should_fail/T2693.stderr   |  12 +-
 testsuite/tests/typecheck/should_fail/T4921.stderr |   2 +-
 4 files changed, 94 insertions(+), 55 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc b96db75c2ea3ea5756dac7d67ca366dab61bafa7