[commit: packages/process] less-cpp, master: Add some clarifying comments (edaedae)

git at git.haskell.org git at git.haskell.org
Tue Dec 15 13:34:30 UTC 2015


Repository : ssh://git@git.haskell.org/process

On branches: less-cpp,master
Link       : http://ghc.haskell.org/trac/ghc/changeset/edaedaee7461560cb3b9ca3a4ef0b3990d95cd7f/process

>---------------------------------------------------------------

commit edaedaee7461560cb3b9ca3a4ef0b3990d95cd7f
Author: Michael Snoyman <michael at fpcomplete.com>
Date:   Mon Nov 2 16:35:09 2015 +0000

    Add some clarifying comments


>---------------------------------------------------------------

edaedaee7461560cb3b9ca3a4ef0b3990d95cd7f
 System/Process/Common.hs | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/System/Process/Common.hs b/System/Process/Common.hs
index e7ce4d9..5d2e180 100644
--- a/System/Process/Common.hs
+++ b/System/Process/Common.hs
@@ -37,6 +37,8 @@ import System.IO.Error
 import Data.Typeable
 import GHC.IO.IOMode
 
+-- We do a minimal amount of CPP here to provide uniform data types across
+-- Windows and POSIX.
 #ifdef WINDOWS
 import Data.Word (Word32)
 import System.Win32.DebugApi (PHANDLE)
@@ -45,7 +47,9 @@ import System.Posix.Types
 #endif
 
 #ifdef WINDOWS
--- Define some missing types for Windows compatibility
+-- Define some missing types for Windows compatibility. Note that these values
+-- will never actually be used, as the setuid/setgid system calls are not
+-- applicable on Windows. No value of this type will ever exist.
 newtype CGid = CGid Word32
 type GroupID = CGid
 type UserID = CGid



More information about the ghc-commits mailing list