[commit: ghc] master: Implement -fwarn-missing-pat-syn-sigs (1883afb)
git at git.haskell.org
git at git.haskell.org
Sat Dec 12 16:39:31 UTC 2015
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/1883afb2eee88c828adf6aa8014bab64dd6e8096/ghc
>---------------------------------------------------------------
commit 1883afb2eee88c828adf6aa8014bab64dd6e8096
Author: Matthew Pickering <matthewtpickering at gmail.com>
Date: Sat Dec 12 16:38:07 2015 +0000
Implement -fwarn-missing-pat-syn-sigs
This adds a warning when a pattern synonym is not accompanied by a
signature in the style of `-fwarn-missing-sigs`.
It is turned on by -Wall.
If the user specifies, `-fwarn-missing-exported-signatures` with
`-fwarn-missing-pat-syn-sigs` then it will only warn when the pattern
synonym is exported.
Test Plan: ./validate
Reviewers: hvr, austin, bgamari
Reviewed By: bgamari
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D1596
GHC Trac Issues: #11053
>---------------------------------------------------------------
1883afb2eee88c828adf6aa8014bab64dd6e8096
compiler/hsSyn/HsBinds.hs | 13 +++++-
compiler/main/DynFlags.hs | 7 +++-
compiler/rename/RnNames.hs | 50 ++++++++++++++++--------
docs/users_guide/7.12.1-notes.rst | 4 ++
docs/users_guide/using-warnings.rst | 11 ++++++
libraries/base/GHC/Exception.hs | 1 +
testsuite/tests/patsyn/should_compile/all.T | 2 -
testsuite/tests/patsyn/should_fail/T11053.hs | 18 +++++++++
testsuite/tests/patsyn/should_fail/T11053.stderr | 19 +++++++++
testsuite/tests/patsyn/should_fail/all.T | 1 +
10 files changed, 104 insertions(+), 22 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 1883afb2eee88c828adf6aa8014bab64dd6e8096
More information about the ghc-commits
mailing list