[commit: ghc] master: Move checking for missing signatures to RnNames.reportUnusedNames (1bd40c8)

git at git.haskell.org git at git.haskell.org
Mon Dec 7 12:10:18 UTC 2015


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/1bd40c860eb0e8da55b8eff536766a6c802347cc/ghc

>---------------------------------------------------------------

commit 1bd40c860eb0e8da55b8eff536766a6c802347cc
Author: Eric Seidel <gridaphobe at gmail.com>
Date:   Mon Dec 7 12:42:38 2015 +0100

    Move checking for missing signatures to RnNames.reportUnusedNames
    
    Checking for missing signatures before renaming the export list is
    prone to errors, so we now perform the check in `reportUnusedNames` at
    which point everything has been renamed.
    
    Test Plan: validate, new test case is T10908
    
    Reviewers: goldfire, simonpj, austin, bgamari
    
    Subscribers: thomie
    
    Projects: #ghc
    
    Differential Revision: https://phabricator.haskell.org/D1561
    
    GHC Trac Issues: #10908


>---------------------------------------------------------------

1bd40c860eb0e8da55b8eff536766a6c802347cc
 compiler/rename/RnNames.hs                        |  63 +++++++++-
 compiler/typecheck/TcBinds.hs                     |  24 +++-
 compiler/typecheck/TcHsSyn.hs                     | 141 +++++-----------------
 compiler/typecheck/TcRnDriver.hs                  |  10 +-
 testsuite/tests/warnings/should_compile/T10908.hs |  10 ++
 testsuite/tests/warnings/should_compile/all.T     |   1 +
 6 files changed, 130 insertions(+), 119 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 1bd40c860eb0e8da55b8eff536766a6c802347cc


More information about the ghc-commits mailing list