[commit: ghc] master: Disable same warnings for normal builds as for validate (#10223) (4c1e1c8)
git at git.haskell.org
git at git.haskell.org
Thu Apr 2 09:42:21 UTC 2015
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/4c1e1c870e294990a44d8d6837742fb0d00f5456/ghc
>---------------------------------------------------------------
commit 4c1e1c870e294990a44d8d6837742fb0d00f5456
Author: Thomas Miedema <thomasmiedema at gmail.com>
Date: Thu Apr 2 11:41:47 2015 +0200
Disable same warnings for normal builds as for validate (#10223)
The default validate settings currently disable some warnings in the
libraries. This patch moves those settings to a new file called
`mk/warnings.mk`, and applies them also to normal builds.
Through uncommenting a line in build.mk, developers can now build with
-Werror.
-Werror is not the default, because:
* We can not guarantee that the build is warning free on platforms we
don't run regularly run validate (as part of continuous integration
systems), and we still want the build to go through on those
platforms.
* quoting rwbarton on irc > "I think -Werror by default has come up in
the past and the argument was that it is too annoying when you are
doing nontrivial development"
Reviewed By: austin
Differential Revision: https://phabricator.haskell.org/D785
>---------------------------------------------------------------
4c1e1c870e294990a44d8d6837742fb0d00f5456
ghc.mk | 15 ++--
mk/build.mk.sample | 3 +
mk/validate-settings.mk | 118 -------------------------------
mk/{validate-settings.mk => warnings.mk} | 63 ++---------------
4 files changed, 17 insertions(+), 182 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 4c1e1c870e294990a44d8d6837742fb0d00f5456
More information about the ghc-commits
mailing list