[commit: ghc] master: Update Cabal submodule & ghc-pkg to use new module re-export types (4b648be)

git at git.haskell.org git at git.haskell.org
Wed Sep 24 21:19:40 UTC 2014


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/4b648be19c75e6c6a8e6f9f93fa12c7a4176f0ae/ghc

>---------------------------------------------------------------

commit 4b648be19c75e6c6a8e6f9f93fa12c7a4176f0ae
Author: Edward Z. Yang <ezyang at cs.stanford.edu>
Date:   Tue Sep 23 16:05:25 2014 +0200

    Update Cabal submodule & ghc-pkg to use new module re-export types
    
    Summary:
    The main change is that Cabal changed the representation of module
    re-exports to distinguish reexports in source .cabal files versus
    re-exports in installed package registraion files.
    
    Cabal now also does the resolution of re-exports to specific installed
    packages itself, so ghc-pkg no longer has to do this. This is a cleaner
    design overall because re-export resolution can fail so it is better to
    do it during package configuration rather than package registration.
    It also simplifies the re-export representation that ghc-pkg has to use.
    
    Add extra ghc-pkg sanity check for module re-exports and duplicates
    
    For re-exports, check that the defining package exists and that it
    exposes the defining module (or for self-rexport exposed or hidden
    modules). Also check that the defining package is actually a direct
    or indirect dependency of the package doing the re-exporting.
    
    Also add a check for duplicate modules in a package, including
    re-exported modules.
    
    Test Plan:
    So far the sanity checks are totally untested. Should add some test
    case to make sure the sanity checks do catch things correctly, and
    don't ban legal things.
    
    Reviewers: austin, duncan
    
    Subscribers: angerman, simonmar, ezyang, carter
    
    Differential Revision: https://phabricator.haskell.org/D183
    
    GHC Trac Issues:


>---------------------------------------------------------------

4b648be19c75e6c6a8e6f9f93fa12c7a4176f0ae
 compiler/main/Packages.lhs            |   6 +-
 ghc.mk                                |   4 +-
 libraries/Cabal                       |   2 +-
 testsuite/tests/cabal/ghcpkg07.stdout |  14 +-
 testsuite/tests/cabal/test7a.pkg      |   3 +-
 testsuite/tests/cabal/test7b.pkg      |   5 +-
 testsuite/tests/perf/haddock/all.T    |   3 +-
 utils/ghc-cabal/Main.hs               |   2 +-
 utils/ghc-cabal/ghc.mk                |   1 +
 utils/ghc-pkg/Main.hs                 | 279 +++++++++-------------------------
 10 files changed, 99 insertions(+), 220 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 4b648be19c75e6c6a8e6f9f93fa12c7a4176f0ae


More information about the ghc-commits mailing list