[commit: ghc] master: Set llc and opt commands on all platforms (918719b)

git at git.haskell.org git at git.haskell.org
Mon Sep 1 20:15:15 UTC 2014


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/918719b936b878ab660f20ceef8afc9e3a898c5a/ghc

>---------------------------------------------------------------

commit 918719b936b878ab660f20ceef8afc9e3a898c5a
Author: Austin Seipp <austin at well-typed.com>
Date:   Mon Sep 1 15:14:07 2014 -0500

    Set llc and opt commands on all platforms
    
    Summary:
    LLVM llc and opt commands should be set on all platforms, including
    Windows. If they're not, GHC tries to execute an unnamed executable,
    resulting in error messages such as:
    
        Error (figuring out LLVM version): : runInteractiveProcess: invalid argument (Invalid argument)
        <no location info>:
            Warning: Couldn't figure out LLVM version!
                     Make sure you have installed LLVM
    
    This regression was introduced in e6bfc596.
    
    Test Plan: Build GHC and test if --info shows sensible values of "LLVM llc command" and "LLVM opt command"
    
    Reviewers: austin, #ghc
    
    Reviewed By: austin, #ghc
    
    Subscribers: austin
    
    Projects: #ghc
    
    Differential Revision: https://phabricator.haskell.org/D190
    
    GHC Trac Issues: #7143


>---------------------------------------------------------------

918719b936b878ab660f20ceef8afc9e3a898c5a
 aclocal.m4 | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/aclocal.m4 b/aclocal.m4
index bdc6c5d..09300f1 100644
--- a/aclocal.m4
+++ b/aclocal.m4
@@ -473,18 +473,18 @@ AC_DEFUN([FP_SETTINGS],
         SettingsWindresCommand="/bin/false"
         SettingsLibtoolCommand="libtool"
         SettingsTouchCommand='touch'
-        if test -z "$LlcCmd"
-        then
-          SettingsLlcCommand="llc"
-        else
-          SettingsLlcCommand="$LlcCmd"
-        fi
-        if test -z "$OptCmd"
-        then
-          SettingsOptCommand="opt"
-        else
-          SettingsOptCommand="$OptCmd"
-        fi
+    fi
+    if test -z "$LlcCmd"
+    then
+      SettingsLlcCommand="llc"
+    else
+      SettingsLlcCommand="$LlcCmd"
+    fi
+    if test -z "$OptCmd"
+    then
+      SettingsOptCommand="opt"
+    else
+      SettingsOptCommand="$OptCmd"
     fi
     SettingsCCompilerFlags="$CONF_CC_OPTS_STAGE2"
     SettingsCCompilerLinkFlags="$CONF_GCC_LINKER_OPTS_STAGE2"



More information about the ghc-commits mailing list