[commit: ghc] master: Make Lexer.x more like the 2010 report (64c9898)

git at git.haskell.org git at git.haskell.org
Mon Sep 1 20:15:07 UTC 2014


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/64c9898f7b5239435f131f5444d62bda23dfc9ef/ghc

>---------------------------------------------------------------

commit 64c9898f7b5239435f131f5444d62bda23dfc9ef
Author: Thomas Miedema <thomasmiedema at gmail.com>
Date:   Mon Sep 1 15:13:00 2014 -0500

    Make Lexer.x more like the 2010 report
    
    Summary:
    I tried reading the lexer and the 2010 report side-by-side. Althought I didn't
    quite finish, here are some small discrepancies that I found.
    
    This revision may be low priority for reviewers, but having these commits just
    in my local repository does no good either.
    
    Changes:
    * $nl was defined, but not used anywhere
    * formfeed is a newline character
    * add \: to $ascsymbol
      For simplification reason, the colon (':') was added to the character
      set $ascsymbol in the 2010 report. Here we make the same change.
    * introduce the macros `qvarid`, `qconid`, `qvarsym` and `qconsym`
    * foreign is a Haskell keyword
    * add/update comments
    
    Test Plan: Harbormaster (is awesome)
    
    Reviewers: simonmar, hvr, austin
    
    Reviewed By: austin
    
    Subscribers: hvr, simonmar, ezyang, carter
    
    Differential Revision: https://phabricator.haskell.org/D180


>---------------------------------------------------------------

64c9898f7b5239435f131f5444d62bda23dfc9ef
 compiler/parser/Lexer.x | 115 ++++++++++++++++++++++++++++++------------------
 1 file changed, 73 insertions(+), 42 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 64c9898f7b5239435f131f5444d62bda23dfc9ef


More information about the ghc-commits mailing list