[commit: haddock] master: Crash when exporting record selectors of data family instances (a6e36fc)
git at git.haskell.org
git at git.haskell.org
Mon Mar 31 18:17:53 UTC 2014
Repository : ssh://git@git.haskell.org/haddock
On branch : master
Link : http://git.haskell.org/haddock.git/commitdiff/a6e36fc8cde675c2b7b2bc8f519221c93f20f207
>---------------------------------------------------------------
commit a6e36fc8cde675c2b7b2bc8f519221c93f20f207
Author: Niklas Haas <git at nand.wakku.to>
Date: Mon Mar 31 20:02:36 2014 +0200
Crash when exporting record selectors of data family instances
This fixes bug #294.
This also fixes a related but never-before-mentioned bug about the
display of GADT record selectors with non-polymorphic type signatures.
Note: Associated data type constructors fail to show up if nothing is
exported that they could be attached to. Exporting any of the data types
in the instance head, or the class + data family itself, causes them to
show up, but in the absence of either of these, exporting just the
associated data type with the constructor itself will result in it
being hidden.
The only scenario I can come up that would involve this kind of
situation involved OverlappingInstances, and even then it can be
mitigated by just exporting the class itself, so I'm not going to solve
it since the logic would most likely be very complicated.
>---------------------------------------------------------------
a6e36fc8cde675c2b7b2bc8f519221c93f20f207
.../ref/{HiddenInstances.html => Bug294.html} | 148 ++++++++++----------
html-test/src/Bug294.hs | 37 +++++
src/Haddock/Interface/Create.hs | 34 +++--
3 files changed, 136 insertions(+), 83 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc a6e36fc8cde675c2b7b2bc8f519221c93f20f207
More information about the ghc-commits
mailing list