[commit: ghc] wip/ext-solver: Refactor and fix bug. (a705a08)
git at git.haskell.org
git at git.haskell.org
Sun Jun 8 21:32:28 UTC 2014
Repository : ssh://git@git.haskell.org/ghc
On branch : wip/ext-solver
Link : http://ghc.haskell.org/trac/ghc/changeset/a705a086cf4cc74c3db2e85318230f69bb70362b/ghc
>---------------------------------------------------------------
commit a705a086cf4cc74c3db2e85318230f69bb70362b
Author: Iavor S. Diatchki <iavor.diatchki at gmail.com>
Date: Sun Jun 8 14:32:16 2014 -0700
Refactor and fix bug.
Now we start a new copy of the solver for each major action we
need to perform (improvement or solving). This does lead to a little
repeated work but not much: we just end asserting the givens in nested
implications multiple times. Since implications tend not be nested
very many times, and usually there aren't many givens anyway, this
should not be a problem.
Note that we are still making extensive use if the solver's incremental
abilities: each of the major actions we perform makes multiple calls
to the solver, and it is important that we can reuse the state we've
already built up.
>---------------------------------------------------------------
a705a086cf4cc74c3db2e85318230f69bb70362b
compiler/typecheck/TcInteract.lhs | 64 ++++++++++++++++++++++++---------------
compiler/typecheck/TcSMonad.lhs | 37 +++-------------------
compiler/typecheck/TcTypeNats.hs | 33 ++++++--------------
3 files changed, 52 insertions(+), 82 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc a705a086cf4cc74c3db2e85318230f69bb70362b
More information about the ghc-commits
mailing list