[commit: ghc] master: rts/Capability.c: fix crash in -threaded mode on UNREG build (ebace69)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/ebace6969f0ec85b1caa0fea265a5f9990a23b2e/ghc

>---------------------------------------------------------------

commit ebace6969f0ec85b1caa0fea265a5f9990a23b2e
Author: Sergei Trofimovich <slyfox at gentoo.org>
Date:   Thu Feb 13 07:26:05 2014 -0600

    rts/Capability.c: fix crash in -threaded mode on UNREG build
    
    UNREG mode has quite nasty invariant to maintain:
        capabilities[0] == &MainCapability
    
    and it's a non-heap memory, while other
    capabilities are dynamically allocated.
    
    Issue #8748
    
    Signed-off-by: Sergei Trofimovich <slyfox at gentoo.org>
    Signed-off-by: Austin Seipp <austin at well-typed.com>


>---------------------------------------------------------------

ebace6969f0ec85b1caa0fea265a5f9990a23b2e
 rts/Capability.c |   22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/rts/Capability.c b/rts/Capability.c
index 5988d42..16b71b7 100644
--- a/rts/Capability.c
+++ b/rts/Capability.c
@@ -357,15 +357,18 @@ moreCapabilities (nat from USED_IF_THREADS, nat to USED_IF_THREADS)
         // BaseReg (eg. unregisterised), so in this case
 	// capabilities[0] must coincide with &MainCapability.
         capabilities[0] = &MainCapability;
+        initCapability(&MainCapability, 0);
     }
-
-    for (i = 0; i < to; i++) {
-        if (i < from) {
-            capabilities[i] = old_capabilities[i];
-        } else {
-            capabilities[i] = stgMallocBytes(sizeof(Capability),
-                                             "moreCapabilities");
-            initCapability(capabilities[i], i);
+    else
+    {
+        for (i = 0; i < to; i++) {
+            if (i < from) {
+                capabilities[i] = old_capabilities[i];
+            } else {
+                capabilities[i] = stgMallocBytes(sizeof(Capability),
+                                                 "moreCapabilities");
+                initCapability(capabilities[i], i);
+            }
         }
     }
 
@@ -983,7 +986,8 @@ freeCapabilities (void)
     nat i;
     for (i=0; i < n_capabilities; i++) {
         freeCapability(capabilities[i]);
-        stgFree(capabilities[i]);
+        if (capabilities[i] != &MainCapability)
+            stgFree(capabilities[i]);
     }
 #else
     freeCapability(&MainCapability);