[commit: ghc] wip/remove-cabal-dep: Switch the package id types to use FastString (rather than String) (575a9e8)

git at git.haskell.org git at git.haskell.org
Sun Aug 24 22:47:46 UTC 2014


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/remove-cabal-dep
Link       : http://ghc.haskell.org/trac/ghc/changeset/575a9e81c8e39496179588a5f93fd616cecc5265/ghc

>---------------------------------------------------------------

commit 575a9e81c8e39496179588a5f93fd616cecc5265
Author: Duncan Coutts <duncan at well-typed.com>
Date:   Sun Aug 24 21:59:03 2014 +0100

    Switch the package id types to use FastString (rather than String)
    
    The conversions should now be correct w.r.t Unicode.
    
    Also move a couple instances to avoid orphan instances.
    
    Strictly speaking there's no need for these types to use FastString as
    they do not need the unique feature. They could just use some other
    compact string type, but ghc's internal utils don't have much support
    for such a type, so we just use FastString.


>---------------------------------------------------------------

575a9e81c8e39496179588a5f93fd616cecc5265
 compiler/basicTypes/Module.lhs |  9 +++++++++
 compiler/main/PackageConfig.hs | 44 +++++++++++++++++++-----------------------
 compiler/main/Packages.lhs     | 28 +++++++++++++--------------
 3 files changed, 43 insertions(+), 38 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 575a9e81c8e39496179588a5f93fd616cecc5265


More information about the ghc-commits mailing list