[commit: ghc] wip/remove-cabal-dep: Simplify conversion in binary serialisation of ghc-pkg db (4feb990)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/remove-cabal-dep
Link       : http://ghc.haskell.org/trac/ghc/changeset/4feb9902dbc7c7b6a285a1a9611b8e5073acd9c8/ghc

>---------------------------------------------------------------

commit 4feb9902dbc7c7b6a285a1a9611b8e5073acd9c8
Author: Duncan Coutts <duncan at well-typed.com>
Date:   Tue Aug 19 01:00:54 2014 +0100

    Simplify conversion in binary serialisation of ghc-pkg db
    
    We can serialise directly, without having to convert some fields to
    string first.
    
    (Part of preparitory work for removing the compiler's dep on Cabal)


>---------------------------------------------------------------

4feb9902dbc7c7b6a285a1a9611b8e5073acd9c8
 .../bin-package-db/Distribution/InstalledPackageInfo/Binary.hs     | 6 ++++++
 utils/ghc-pkg/Main.hs                                              | 7 +++----
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/libraries/bin-package-db/Distribution/InstalledPackageInfo/Binary.hs b/libraries/bin-package-db/Distribution/InstalledPackageInfo/Binary.hs
index baf8a05..9fd27f6 100644
--- a/libraries/bin-package-db/Distribution/InstalledPackageInfo/Binary.hs
+++ b/libraries/bin-package-db/Distribution/InstalledPackageInfo/Binary.hs
@@ -22,8 +22,10 @@ module Distribution.InstalledPackageInfo.Binary (
 import Distribution.Version
 import Distribution.Package hiding (depends)
 import Distribution.License
+import Distribution.ModuleName as ModuleName
 import Distribution.ModuleExport
 import Distribution.InstalledPackageInfo as IPI
+import Distribution.Text (display)
 import Data.Binary as Bin
 import Control.Exception as Exception
 
@@ -164,6 +166,10 @@ instance Binary Version where
 deriving instance Binary PackageName
 deriving instance Binary InstalledPackageId
 
+instance Binary ModuleName where
+  put = put . display
+  get = fmap ModuleName.fromString get
+
 instance Binary m => Binary (ModuleExport m) where
   put (ModuleExport a b c d) = do put a; put b; put c; put d
   get = do a <- get; b <- get; c <- get; d <- get;
diff --git a/utils/ghc-pkg/Main.hs b/utils/ghc-pkg/Main.hs
index c88b814..554640e 100644
--- a/utils/ghc-pkg/Main.hs
+++ b/utils/ghc-pkg/Main.hs
@@ -706,8 +706,7 @@ readParseDatabase verbosity mb_user_conf use_cache path
                           when (verbosity > Normal) $
                              infoLn ("using cache: " ++ cache)
                           pkgs <- myReadBinPackageDB cache
-                          let pkgs' = map convertPackageInfoIn pkgs
-                          mkPackageDB pkgs'
+                          mkPackageDB pkgs
                       else do
                           when (verbosity >= Normal) $ do
                               warn ("WARNING: cache is out of date: "
@@ -735,7 +734,7 @@ readParseDatabase verbosity mb_user_conf use_cache path
 -- bytestring 0.9.0.x (fixed in 0.9.1.x) where the file wasn't closed
 -- after it has been completely read, leading to a sharing violation
 -- later.
-myReadBinPackageDB :: FilePath -> IO [InstalledPackageInfoString]
+myReadBinPackageDB :: FilePath -> IO [InstalledPackageInfo]
 myReadBinPackageDB filepath = do
   h <- openBinaryFile filepath ReadMode
   sz <- hFileSize h
@@ -1021,7 +1020,7 @@ updateDBCache verbosity db = do
   let filename = location db </> cachefilename
   when (verbosity > Normal) $
       infoLn ("writing cache " ++ filename)
-  writeBinaryFileAtomic filename (map convertPackageInfoOut (packages db))
+  writeBinaryFileAtomic filename (packages db)
     `catchIO` \e ->
       if isPermissionError e
       then die (filename ++ ": you don't have permission to modify this file")