[commit: ghc] master: Tweak linting rules. (ba9277c)

git at git.haskell.org git at git.haskell.org
Sun Aug 10 19:23:03 UTC 2014


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/ba9277c72ab39bbd85ef52524151bf27a6c106f8/ghc

>---------------------------------------------------------------

commit ba9277c72ab39bbd85ef52524151bf27a6c106f8
Author: Edward Z. Yang <ezyang at cs.stanford.edu>
Date:   Sat Aug 9 02:05:53 2014 +0100

    Tweak linting rules.
    
    Summary:
    - Removed the default text rule that was applied to all files; it
      produced way too many spurious warnings.  For now, text lint is applied
      to C, Haskell and Shell.  Add more if you care.
    
    - Makefiles and shell scripts had their max line length bumped a healthy
      amount.
    
    A pile of files still fail to lint, so these might even still be too
    aggressive.
    
    Signed-off-by: Edward Z. Yang <ezyang at cs.stanford.edu>
    
    Test Plan: none
    
    Reviewers: hvr, austin
    
    Subscribers: simonmar, relrod, ezyang, carter
    
    Differential Revision: https://phabricator.haskell.org/D131


>---------------------------------------------------------------

ba9277c72ab39bbd85ef52524151bf27a6c106f8
 .arclint | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/.arclint b/.arclint
index bb16f08..f798015 100644
--- a/.arclint
+++ b/.arclint
@@ -12,24 +12,34 @@
     "nolint": {
       "type": "nolint"
     },
-    "text": {
+    "haskell": {
       "type": "text",
-      "exclude": [ "(\\.xml)", "(Makefile)", "(\\.mk)" ],
+      "include": ["(\\.(l?hs(-boot)?|x|y\\.pp)(\\.in)?$)"],
       "severity": {
         "5": "disabled"
       }
     },
+    "c": {
+      "type": "text",
+      "include": ["(\\.(c|h)(\\.in)?$)"]
+    },
     "text-xml": {
       "type": "text",
-      "include": "(\\.xml)",
+      "include": "(\\.xml$)",
       "severity": {
         "5": "disabled",
         "3": "disabled"
       }
     },
+    "shell": {
+      "type": "text",
+      "include": [ "(\\.sh$)" ],
+      "text.max-line-length": 200
+    },
     "makefiles": {
       "type": "text",
-      "include": [ "(Makefile)", "(\\.mk)" ],
+      "include": [ "(Makefile$)", "(\\.mk$)" ],
+      "text.max-line-length": 200,
       "severity": {
         "2": "disabled"
       }



More information about the ghc-commits mailing list