[commit: ghc] master: Fix some typos in recent comments/notes (18ac546)
git at git.haskell.org
git at git.haskell.org
Thu Aug 7 11:24:48 UTC 2014
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/18ac546d8db93f170cdbc29da8b7118272b065e7/ghc
>---------------------------------------------------------------
commit 18ac546d8db93f170cdbc29da8b7118272b065e7
Author: Gabor Greif <ggreif at gmail.com>
Date: Thu Aug 7 13:22:25 2014 +0200
Fix some typos in recent comments/notes
>---------------------------------------------------------------
18ac546d8db93f170cdbc29da8b7118272b065e7
compiler/coreSyn/CoreSyn.lhs | 2 +-
compiler/coreSyn/CoreUtils.lhs | 4 ++--
compiler/prelude/PrimOp.lhs | 18 +++++++++---------
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/compiler/coreSyn/CoreSyn.lhs b/compiler/coreSyn/CoreSyn.lhs
index 3efc647..12a60da 100644
--- a/compiler/coreSyn/CoreSyn.lhs
+++ b/compiler/coreSyn/CoreSyn.lhs
@@ -363,7 +363,7 @@ In this situation you should use @case@ rather than a @let at . The function
alternatively use 'MkCore.mkCoreLet' rather than this constructor directly,
which will generate a @case@ if necessary
-Th let/app invariant is intially enforced by DsUtils.mkCoreLet and mkCoreApp
+Th let/app invariant is initially enforced by DsUtils.mkCoreLet and mkCoreApp
Note [CoreSyn case invariants]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
diff --git a/compiler/coreSyn/CoreUtils.lhs b/compiler/coreSyn/CoreUtils.lhs
index 369af16..baf7e4f 100644
--- a/compiler/coreSyn/CoreUtils.lhs
+++ b/compiler/coreSyn/CoreUtils.lhs
@@ -913,7 +913,7 @@ it's applied only to dictionaries.
-- c) without causing a write side effect (e.g. writing a mutable variable)
-- d) without throwing a Haskell exception
-- e) without risking an unchecked runtime exception (array out of bounds,
--- divide byzero)
+-- divide by zero)
--
-- For @exprOkForSideEffects@ the list is the same, but omitting (e).
--
@@ -922,7 +922,7 @@ it's applied only to dictionaries.
-- exprOkForSpeculation implies exprOkForSideEffects
--
-- See Note [PrimOp can_fail and has_side_effects] in PrimOp
--- and Note [Implementation: how can_fail/has_side_effects affect transformaations]
+-- and Note [Implementation: how can_fail/has_side_effects affect transformations]
--
-- As an example of the considerations in this test, consider:
--
diff --git a/compiler/prelude/PrimOp.lhs b/compiler/prelude/PrimOp.lhs
index 2e33406..198078b 100644
--- a/compiler/prelude/PrimOp.lhs
+++ b/compiler/prelude/PrimOp.lhs
@@ -354,20 +354,20 @@ data dependencies of the state token to enforce write-effect ordering
* NB3: *Read* effects (like reading an IORef) don't count here,
because it doesn't matter if we don't do them, or do them more than
- once. *Sequencing* is maintain by the data dependency of the state
+ once. *Sequencing* is maintained by the data dependency of the state
token.
---------- can_fail ----------------------------
-A primop "can_fail" if if can fail with an *unchecked* exception on
+A primop "can_fail" if it can fail with an *unchecked* exception on
some elements of its input domain. Main examples:
- division (fails on zero demoninator
+ division (fails on zero demoninator)
array indexing (fails if the index is out of bounds)
-An "unchecked exception" is one that is an outright error, not
-turned into a Haskell exception), such as seg-fault or
+An "unchecked exception" is one that is an outright error, (not
+turned into a Haskell exception,) such as seg-fault or
divide-by-zero error. Such can_fail primops are ALWAYS surrounded
with a test that checks for the bad cases, but we need to be
-very careful about code motion that might move the out of
+very careful about code motion that might move it out of
the scope of the test.
Note [Transformations affected by can_fail and has_side_effects]
@@ -404,7 +404,7 @@ Duplicate YES NO
- Synchronous Haskell exceptions, eg from raiseIO#, are treated
+ Synchronous Haskell exceptions, e.g. from raiseIO#, are treated
as has_side_effects and hence are not discarded.
* Float in. You can float a can_fail or has_side_effects primop
@@ -449,7 +449,7 @@ Duplicate YES NO
However, it's fine to duplicate a can_fail primop. That is really
the only difference between can_fail and has_side_effects.
-Note [Implementation: how can_fail/has_side_effects affect transformaations]
+Note [Implementation: how can_fail/has_side_effects affect transformations]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
How do we ensure that that floating/duplication/discarding are done right
in the simplifier?
@@ -487,7 +487,7 @@ primOpOkForSpeculation op
= primOpOkForSideEffects op
&& not (primOpOutOfLine op || primOpCanFail op)
-- I think the "out of line" test is because out of line things can
- -- be expensive (eg sine, consine), and so we may not want to speculate them
+ -- be expensive (eg sine, cosine), and so we may not want to speculate them
primOpOkForSideEffects :: PrimOp -> Bool
primOpOkForSideEffects op
More information about the ghc-commits
mailing list