[commit: ghc] master: rts: Fix leak of file archive handle (e597f5f)

git at git.haskell.org git at git.haskell.org
Tue Apr 29 19:14:41 UTC 2014


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/e597f5feb065c075c86715e24bf0ebd341fa8b9e/ghc

>---------------------------------------------------------------

commit e597f5feb065c075c86715e24bf0ebd341fa8b9e
Author: Austin Seipp <austin at well-typed.com>
Date:   Tue Apr 29 09:05:38 2014 -0500

    rts: Fix leak of file archive handle
    
    Issue discovered by Coverity Scan, CID 43171.
    
    Signed-off-by: Austin Seipp <austin at well-typed.com>


>---------------------------------------------------------------

e597f5feb065c075c86715e24bf0ebd341fa8b9e
 rts/Linker.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/rts/Linker.c b/rts/Linker.c
index 1b0d48f..146e2d5 100644
--- a/rts/Linker.c
+++ b/rts/Linker.c
@@ -2718,6 +2718,7 @@ loadArchive( pathchar *path )
 
             if (0 == loadOc(oc)) {
                 stgFree(fileName);
+                fclose(f);
                 return 0;
             }
         }



More information about the ghc-commits mailing list