[commit: ghc] master: Fix stale comments around closed type families. (9b456df)

Richard Eisenberg eir at cis.upenn.edu
Fri Jun 28 10:36:51 CEST 2013


Repository : http://darcs.haskell.org/ghc.git/

On branch  : master

https://github.com/ghc/ghc/commit/9b456df49201a2c7f37d330909c73b30c16bcdf4

>---------------------------------------------------------------

commit 9b456df49201a2c7f37d330909c73b30c16bcdf4
Author: Richard Eisenberg <eir at cis.upenn.edu>
Date:   Thu Jun 27 13:19:36 2013 +0100

    Fix stale comments around closed type families.

>---------------------------------------------------------------

 compiler/typecheck/FamInst.lhs | 2 +-
 compiler/types/FamInstEnv.lhs  | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/compiler/typecheck/FamInst.lhs b/compiler/typecheck/FamInst.lhs
index 3f220b1..3ca28ef 100644
--- a/compiler/typecheck/FamInst.lhs
+++ b/compiler/typecheck/FamInst.lhs
@@ -35,7 +35,7 @@ import Maybes
 import TcMType
 import TcType
 import Name
-import VarSet -- RAE
+import VarSet
 import Control.Monad
 import Data.Map (Map)
 import qualified Data.Map as Map
diff --git a/compiler/types/FamInstEnv.lhs b/compiler/types/FamInstEnv.lhs
index 85ad7f4..d7bdecc 100644
--- a/compiler/types/FamInstEnv.lhs
+++ b/compiler/types/FamInstEnv.lhs
@@ -784,8 +784,7 @@ findBranch (CoAxBranch { cab_tvs = tpl_tvs, cab_lhs = tpl_lhs, cab_incomps = inc
       Just subst -- matching worked. now, check for apartness.
         |  all (isSurelyApart
                 . tcApartTys instanceBindFun target_tys
-                . coAxBranchLHS) $ -- RAE: This is horribly inefficient
-             incomps
+                . coAxBranchLHS) incomps
         -> -- matching worked & we're apart from all incompatible branches. success
            Just (ind, substTyVars subst tpl_tvs)
 





More information about the ghc-commits mailing list