[commit: base] master: Remove some unnecessary SOURCE imports (5fe76f3)

Ian Lynagh igloo at earth.li
Sun Jun 2 14:12:28 CEST 2013


Repository : ssh://darcs.haskell.org//srv/darcs/packages/base

On branch  : master

https://github.com/ghc/packages-base/commit/5fe76f3ab4fc8b7e77e498f0543ffbc5347860c5

>---------------------------------------------------------------

commit 5fe76f3ab4fc8b7e77e498f0543ffbc5347860c5
Author: Ian Lynagh <ian at well-typed.com>
Date:   Sun Jun 2 12:47:28 2013 +0100

    Remove some unnecessary SOURCE imports

>---------------------------------------------------------------

 Data/OldTypeable.hs          |    6 +-----
 Data/OldTypeable.hs-boot     |   10 ----------
 Data/OldTypeable/Internal.hs |    6 +-----
 3 files changed, 2 insertions(+), 20 deletions(-)

diff --git a/Data/OldTypeable.hs b/Data/OldTypeable.hs
index bed7ad1..58d4f33 100644
--- a/Data/OldTypeable.hs
+++ b/Data/OldTypeable.hs
@@ -100,11 +100,7 @@ import GHC.Base
 import GHC.Err          (undefined)
 
 import GHC.Fingerprint.Type
-import {-# SOURCE #-} GHC.Fingerprint
-   -- loop: GHC.Fingerprint -> Foreign.Ptr -> Data.Typeable
-   -- Better to break the loop here, because we want non-SOURCE imports
-   -- of Data.Typeable as much as possible so we can optimise the derived
-   -- instances.
+import GHC.Fingerprint
 
 #endif
 
diff --git a/Data/OldTypeable.hs-boot b/Data/OldTypeable.hs-boot
deleted file mode 100644
index 6c1f795..0000000
--- a/Data/OldTypeable.hs-boot
+++ /dev/null
@@ -1,10 +0,0 @@
-{-# LANGUAGE Trustworthy #-}
-{-# LANGUAGE NoImplicitPrelude #-}
-
-module Data.OldTypeable (Typeable, mkTyConApp, cast) where
-
-import Data.Maybe
-import {-# SOURCE #-} Data.Typeable.Internal
-
-cast :: (Typeable a, Typeable b) => a -> Maybe b
-
diff --git a/Data/OldTypeable/Internal.hs b/Data/OldTypeable/Internal.hs
index 5c26130..739b4e8 100644
--- a/Data/OldTypeable/Internal.hs
+++ b/Data/OldTypeable/Internal.hs
@@ -75,11 +75,7 @@ import GHC.Arr          ( Array, STArray )
 import Data.Int
 
 import GHC.Fingerprint.Type
-import {-# SOURCE #-} GHC.Fingerprint
-   -- loop: GHC.Fingerprint -> Foreign.Ptr -> Data.Typeable
-   -- Better to break the loop here, because we want non-SOURCE imports
-   -- of Data.Typeable as much as possible so we can optimise the derived
-   -- instances.
+import GHC.Fingerprint
 
 -- | A concrete representation of a (monomorphic) type.  'TypeRep'
 -- supports reasonably efficient equality.





More information about the ghc-commits mailing list