[commit: ghc] master: Remove spurious extra brace in LLVM metadata (405a20c)

David Terei davidterei at gmail.com
Sat Jul 6 02:00:50 CEST 2013


Repository : http://darcs.haskell.org/ghc.git/

On branch  : master

https://github.com/ghc/ghc/commit/405a20c671df30a977f72f6ee79a3dfc4dac60e5

>---------------------------------------------------------------

commit 405a20c671df30a977f72f6ee79a3dfc4dac60e5
Author: Peter Wortmann <scpmw at leeds.ac.uk>
Date:   Thu Jul 4 17:16:45 2013 +0100

    Remove spurious extra brace in LLVM metadata
    
    This actually caused a segfault in the optimized stage 2 compiler due to
    wrong TBAA data.
    
    Signed-off-by: David Terei <davidterei at gmail.com>

>---------------------------------------------------------------

 compiler/llvmGen/Llvm/PpLlvm.hs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compiler/llvmGen/Llvm/PpLlvm.hs b/compiler/llvmGen/Llvm/PpLlvm.hs
index 87be8f6..fca1a7c 100644
--- a/compiler/llvmGen/Llvm/PpLlvm.hs
+++ b/compiler/llvmGen/Llvm/PpLlvm.hs
@@ -105,7 +105,7 @@ ppLlvmMetas metas = vcat $ map ppLlvmMeta metas
 -- | Print out an LLVM metadata definition.
 ppLlvmMeta :: MetaDecl -> SDoc
 ppLlvmMeta (MetaUnamed n m)
-  = exclamation <> int n <> text " = metadata !" <> braces (ppLlvmMetaExpr m)
+  = exclamation <> int n <> text " = " <> ppLlvmMetaExpr m
 
 ppLlvmMeta (MetaNamed n m)
   = exclamation <> ftext n <> text " = !" <> braces nodes





More information about the ghc-commits mailing list