[commit: process] master: Fix final warning in System.Process.Internals (ab7e650)
Ian Lynagh
igloo at earth.li
Wed Feb 20 00:54:34 CET 2013
Repository : ssh://darcs.haskell.org//srv/darcs/packages/process
On branch : master
http://hackage.haskell.org/trac/ghc/changeset/ab7e650c7a1301cc53f28356fbd84661bd435bb0
>---------------------------------------------------------------
commit ab7e650c7a1301cc53f28356fbd84661bd435bb0
Author: Ian Lynagh <igloo at earth.li>
Date: Tue Feb 19 23:53:57 2013 +0000
Fix final warning in System.Process.Internals
>---------------------------------------------------------------
System/Process/Internals.hs | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/System/Process/Internals.hs b/System/Process/Internals.hs
index 36c9235..f94dc52 100644
--- a/System/Process/Internals.hs
+++ b/System/Process/Internals.hs
@@ -1,7 +1,5 @@
{-# LANGUAGE CPP, ForeignFunctionInterface, RecordWildCards #-}
{-# OPTIONS_HADDOCK hide #-}
--- TODO: Remove this pragma:
-{-# OPTIONS -fno-warn-deprecations #-}
#ifdef __GLASGOW_HASKELL__
{-# LANGUAGE Trustworthy #-}
#endif
@@ -139,12 +137,11 @@ throwErrnoIfBadPHandle :: String -> IO PHANDLE -> IO PHANDLE
throwErrnoIfBadPHandle = throwErrnoIfNull
-- On Windows, we have to close this HANDLE when it is no longer required,
--- hence we add a finalizer to it, using an IORef as the box on which to
--- attach the finalizer.
+-- hence we add a finalizer to it
mkProcessHandle :: PHANDLE -> IO ProcessHandle
mkProcessHandle h = do
m <- newMVar (OpenHandle h)
- addMVarFinalizer m (processHandleFinaliser m)
+ _ <- mkWeakMVar m (processHandleFinaliser m)
return (ProcessHandle m)
processHandleFinaliser :: MVar ProcessHandle__ -> IO ()
More information about the ghc-commits
mailing list