[commit: packages/Cabal] ghc-head: Expand a comment. (d79ae84)

git at git.haskell.org git at git.haskell.org
Mon Aug 26 23:25:38 CEST 2013


Repository : ssh://git@git.haskell.org/Cabal

On branch  : ghc-head
Link       : http://git.haskell.org/?p=packages/Cabal.git;a=commit;h=d79ae84725a666caef359cc00e1fc838903f66a4

>---------------------------------------------------------------

commit d79ae84725a666caef359cc00e1fc838903f66a4
Author: Mikhail Glushenkov <mikhail.glushenkov at gmail.com>
Date:   Sat May 18 01:16:01 2013 +0200

    Expand a comment.


>---------------------------------------------------------------

d79ae84725a666caef359cc00e1fc838903f66a4
 cabal-install/Main.hs |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/cabal-install/Main.hs b/cabal-install/Main.hs
index 7d11a54..5fff705 100644
--- a/cabal-install/Main.hs
+++ b/cabal-install/Main.hs
@@ -499,9 +499,11 @@ installAction (configFlags, configExFlags, installFlags, haddockFlags)
     maybeAddCompilerTimestampRecord verbosity sandboxDir indexFile
       (compilerId comp) platform
 
-  -- FIXME: Passing 'SandboxPackageInfo' unconditionally means that 'install'
-  -- will sometimes reinstall modified add-source deps. Probably not a big
-  -- problem since 'build', 'test' etc are already doing it.
+  -- FIXME: Passing 'SandboxPackageInfo' to install unconditionally here means
+  -- that 'cabal install some-package' inside a sandbox will sometimes reinstall
+  -- modified add-source deps, even if they are not among the dependencies of
+  -- 'some-package'. Probably not a big problem since 'build', 'test' etc are
+  -- already reinstalling modified add-source deps.
   maybeWithSandboxPackageInfo verbosity configFlags'' globalFlags'
                               comp platform conf useSandbox $ \mSandboxPkgInfo ->
                               maybeWithSandboxDirOnSearchPath useSandbox $





More information about the ghc-commits mailing list