[commit: packages/Cabal] ghc-head: Fix BuildTestSuiteDetailedV09 on GHC <7.6 (3de2d9a)

git at git.haskell.org git at git.haskell.org
Mon Aug 26 23:22:37 CEST 2013


Repository : ssh://git@git.haskell.org/Cabal

On branch  : ghc-head
Link       : http://git.haskell.org/?p=packages/Cabal.git;a=commit;h=3de2d9a4d6ff7478f8c30ff910ee9df3d742c9c8

>---------------------------------------------------------------

commit 3de2d9a4d6ff7478f8c30ff910ee9df3d742c9c8
Author: Thomas Tuegel <ttuegel at gmail.com>
Date:   Sun Apr 28 15:00:27 2013 -0500

    Fix BuildTestSuiteDetailedV09 on GHC <7.6


>---------------------------------------------------------------

3de2d9a4d6ff7478f8c30ff910ee9df3d742c9c8
 Cabal/tests/PackageTests.hs                        |   21 ++++++++++++++------
 .../BuildTestSuiteDetailedV09/Check.hs             |    9 ++++++---
 2 files changed, 21 insertions(+), 9 deletions(-)

diff --git a/Cabal/tests/PackageTests.hs b/Cabal/tests/PackageTests.hs
index 69b6c80..7cec438 100644
--- a/Cabal/tests/PackageTests.hs
+++ b/Cabal/tests/PackageTests.hs
@@ -9,7 +9,8 @@ module Main where
 import Data.Version (Version(Version))
 import Distribution.Simple.Utils (cabalVersion)
 import Distribution.Text (display)
-import System.Directory (setCurrentDirectory)
+import System.Directory (getCurrentDirectory, setCurrentDirectory)
+import System.FilePath ((</>))
 import Test.Framework (Test, TestName, defaultMain, testGroup)
 import Test.Framework.Providers.HUnit (hUnitTestToTests)
 import qualified Test.HUnit as HUnit
@@ -29,7 +30,7 @@ import PackageTests.BuildDeps.TargetSpecificDeps1.Check
 import PackageTests.BuildDeps.TargetSpecificDeps2.Check
 import PackageTests.BuildDeps.TargetSpecificDeps3.Check
 import PackageTests.BuildTestSuiteDetailedV09.Check
-import PackageTests.PackageTester (compileSetup)
+import PackageTests.PackageTester (PackageSpec(..), compileSetup)
 import PackageTests.PathsModule.Executable.Check
 import PackageTests.PathsModule.Library.Check
 import PackageTests.PreProcess.Check
@@ -43,8 +44,8 @@ import PackageTests.TestSuiteExeV10.Check
 hunit :: TestName -> HUnit.Test -> Test
 hunit name test = testGroup name $ hUnitTestToTests test
 
-tests :: Version -> [Test]
-tests version =
+tests :: Version -> PackageSpec -> [Test]
+tests version inplaceSpec =
     [ hunit "BuildDeps/SameDepsAllRound"
       PackageTests.BuildDeps.SameDepsAllRound.Check.suite
       -- The two following tests were disabled by Johan Tibell as
@@ -79,7 +80,7 @@ tests version =
     , hunit "EmptyLib/emptyLib"
       PackageTests.EmptyLib.Check.emptyLib
     , hunit "BuildTestSuiteDetailedV09"
-      PackageTests.BuildTestSuiteDetailedV09.Check.suite
+      $ PackageTests.BuildTestSuiteDetailedV09.Check.suite inplaceSpec
     ] ++
     -- These tests are only required to pass on cabal version >= 1.7
     (if version >= Version [1, 7] []
@@ -104,9 +105,17 @@ tests version =
 
 main :: IO ()
 main = do
+    wd <- getCurrentDirectory
+    let dbFile = wd </> "dist/package.conf.inplace"
+        inplaceSpec = PackageSpec
+            { directory = []
+            , configOpts = [ "--package-db=" ++ dbFile
+                           , "--constraint=Cabal == " ++ display cabalVersion
+                           ]
+            }
     putStrLn $ "Cabal test suite - testing cabal version " ++
         display cabalVersion
     setCurrentDirectory "tests"
     -- Create a shared Setup executable to speed up Simple tests
     compileSetup "."
-    defaultMain (tests cabalVersion)
+    defaultMain (tests cabalVersion inplaceSpec)
diff --git a/Cabal/tests/PackageTests/BuildTestSuiteDetailedV09/Check.hs b/Cabal/tests/PackageTests/BuildTestSuiteDetailedV09/Check.hs
index f23b0ac..33214d6 100644
--- a/Cabal/tests/PackageTests/BuildTestSuiteDetailedV09/Check.hs
+++ b/Cabal/tests/PackageTests/BuildTestSuiteDetailedV09/Check.hs
@@ -5,10 +5,13 @@ import System.FilePath ((</>))
 
 import PackageTests.PackageTester
 
-suite :: Test
-suite = TestCase $ do
+suite :: PackageSpec -> Test
+suite inplaceSpec = TestCase $ do
     let dir = "PackageTests" </> "BuildTestSuiteDetailedV09"
-        spec = PackageSpec dir ["--enable-tests"]
+        spec = inplaceSpec
+            { directory = dir
+            , configOpts = "--enable-tests" : configOpts inplaceSpec
+            }
     confResult <- cabal_configure spec
     assertEqual "configure failed!" (successful confResult) True
     buildResult <- cabal_build spec





More information about the ghc-commits mailing list